Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/linux: implement sdk_path_if_needed #7145

Merged
merged 1 commit into from Mar 10, 2020

Conversation

@dawidd6
Copy link
Member

dawidd6 commented Mar 10, 2020

Should fix:

==> brew install --verbose --build-bottle nng
==> Downloading https://github.com/nanomsg/nng/archive/v1.3.0.tar.gz
Already downloaded: /github/home/.cache/Homebrew/downloads/39285f43e0d5b84ffee6cf98ad37b588dc3255aafddd606b0e75867ba7378347--nng-1.3.0.tar.gz
==> Verifying 39285f43e0d5b84ffee6cf98ad37b588dc3255aafddd606b0e75867ba7378347--nng-1.3.0.tar.gz checksum
tar xof /github/home/.cache/Homebrew/downloads/39285f43e0d5b84ffee6cf98ad37b588dc3255aafddd606b0e75867ba7378347--nng-1.3.0.tar.gz -C /tmp/d20200310-6203-14mr2v
cp -pR /tmp/d20200310-6203-14mr2v/nng-1.3.0/. /tmp/nng-20200310-6203-qlxge6/nng-1.3.0
chmod -Rf +w /tmp/d20200310-6203-14mr2v
Error: An exception occurred within a child process:
  NoMethodError: undefined method `sdk_path_if_needed' for OS::Mac:Module
==> FAILED

and prevent other breakages on linux.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@dawidd6 dawidd6 mentioned this pull request Mar 10, 2020
4 of 6 tasks complete
@Bo98
Bo98 approved these changes Mar 10, 2020
@dawidd6 dawidd6 force-pushed the dawidd6:linux-mac-sdk-if-needed branch from e94d694 to 131257a Mar 10, 2020
@dawidd6 dawidd6 force-pushed the dawidd6:linux-mac-sdk-if-needed branch from 131257a to e097dce Mar 10, 2020
@sjackman sjackman merged commit 89f3a33 into Homebrew:master Mar 10, 2020
3 checks passed
3 checks passed
tests (ubuntu-latest)
Details
tests (macOS-latest)
Details
coverage/coveralls First build on linux-mac-sdk-if-needed at 73.398%
Details
@dawidd6 dawidd6 deleted the dawidd6:linux-mac-sdk-if-needed branch Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.