From badcaa15e43f776a52b0107c932cf305ad57ccaa Mon Sep 17 00:00:00 2001 From: Gautham G Date: Sun, 15 Mar 2020 17:02:31 +0530 Subject: [PATCH] ARGV: Deprecate ARGV.keep_tmp? --- Library/Homebrew/build.rb | 2 +- Library/Homebrew/dev-cmd/update-test.rb | 2 +- Library/Homebrew/extend/ARGV.rb | 4 ---- Library/Homebrew/formula.rb | 4 ++-- Library/Homebrew/formula_installer.rb | 2 +- 5 files changed, 5 insertions(+), 9 deletions(-) diff --git a/Library/Homebrew/build.rb b/Library/Homebrew/build.rb index 9072d5e3edfc0..cf722b15d8f4c 100644 --- a/Library/Homebrew/build.rb +++ b/Library/Homebrew/build.rb @@ -119,7 +119,7 @@ def install # which is not known until after the formula has been staged. ENV["HOMEBREW_FORMULA_PREFIX"] = formula.prefix - staging.retain! if ARGV.keep_tmp? + staging.retain! if Homebrew.args.keep_tmp? formula.patch if Homebrew.args.git? diff --git a/Library/Homebrew/dev-cmd/update-test.rb b/Library/Homebrew/dev-cmd/update-test.rb index fdf208dd4946e..45fc962d874cf 100644 --- a/Library/Homebrew/dev-cmd/update-test.rb +++ b/Library/Homebrew/dev-cmd/update-test.rb @@ -123,6 +123,6 @@ def update_test end end ensure - FileUtils.rm_rf "update-test" unless args.keep_tmp? + FileUtils.rm_rf "update-test" unless Homebrew.args.keep_tmp? end end diff --git a/Library/Homebrew/extend/ARGV.rb b/Library/Homebrew/extend/ARGV.rb index adf545f7fbe5a..82628c2bf199a 100644 --- a/Library/Homebrew/extend/ARGV.rb +++ b/Library/Homebrew/extend/ARGV.rb @@ -31,10 +31,6 @@ def debug? flag?("--debug") || !ENV["HOMEBREW_DEBUG"].nil? end - def keep_tmp? - include? "--keep-tmp" - end - def homebrew_developer? !ENV["HOMEBREW_DEVELOPER"].nil? end diff --git a/Library/Homebrew/formula.rb b/Library/Homebrew/formula.rb index 155287635f657..1df01f60a641e 100644 --- a/Library/Homebrew/formula.rb +++ b/Library/Homebrew/formula.rb @@ -1126,7 +1126,7 @@ def patch def brew @prefix_returns_versioned_prefix = true stage do |staging| - staging.retain! if ARGV.keep_tmp? + staging.retain! if Homebrew.args.keep_tmp? prepare_patches begin @@ -1765,7 +1765,7 @@ def run_test Utils.set_git_name_email! mktemp("#{name}-test") do |staging| - staging.retain! if ARGV.keep_tmp? + staging.retain! if Homebrew.args.keep_tmp? @testpath = staging.tmpdir test_env[:HOME] = @testpath setup_home @testpath diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb index 5bcea9608804c..0cc5470bcb5e2 100644 --- a/Library/Homebrew/formula_installer.rb +++ b/Library/Homebrew/formula_installer.rb @@ -703,7 +703,7 @@ def sanitized_argv_options args << "--debug" if debug? args << "--cc=#{ARGV.cc}" if ARGV.cc args << "--default-fortran-flags" if ARGV.include? "--default-fortran-flags" - args << "--keep-tmp" if ARGV.keep_tmp? + args << "--keep-tmp" if Homebrew.args.keep_tmp? if ARGV.env args << "--env=#{ARGV.env}"