New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formula not found handling #96

Merged
merged 1 commit into from Aug 10, 2016

Conversation

Projects
None yet
7 participants
@mistydemeo
Copy link
Contributor

mistydemeo commented Apr 15, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran brew tests with your changes locally?

As pointed out by a user on twitter, our formula-not-found error handling could stand to be a bit clearer.

@dunn

This comment has been minimized.

Copy link
Contributor

dunn commented Apr 16, 2016

🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Apr 16, 2016

:shipit: 👍 🐶 🐕 🐩

@@ -142,6 +142,8 @@ def install
rescue FormulaUnavailableError => e
if (blacklist = blacklisted?(e.name))
ofail "#{e.message}\n#{blacklist}"
elsif e.name == "updog"
ofail "What's updog?"

This comment has been minimized.

@xu-cheng

xu-cheng Apr 16, 2016

Contributor

Just want to ask whether it's better to put this Easter egg into blacklist rather than a separate if else branch.

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented May 3, 2016

@mistydemeo Any thoughts on @xu-cheng's comment here?

@MikeMcQuaid MikeMcQuaid merged commit fdf55e7 into Homebrew:master Aug 10, 2016

1 check passed

default Build finished.
Details
@arthurnn

This comment has been minimized.

Copy link

arthurnn commented Sep 21, 2016

🐶

@zmwangx

This comment has been minimized.

Copy link
Contributor

zmwangx commented Sep 21, 2016

Locking conversation to avoid attracting more dog emojis.

@Homebrew Homebrew locked and limited conversation to collaborators Sep 21, 2016

@mistydemeo mistydemeo deleted the mistydemeo:updog branch Jan 30, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.