Skip to content
Permalink
Branch: master
Commits on Feb 6, 2020
  1. Merge pull request #246 from Homebrew/fix-formula-analytics-flags-aga…

    issyl0 committed Feb 6, 2020
    …in-again
    
    Fix brew formula-analytics --json --build-error category flags again
  2. Fix brew formula-analytics --json --build-error category flags again

    issyl0 committed Feb 6, 2020
    - Follow up to #244.
    - The confusion between what needs `--` and what doesn't strikes again!
      It doesn't help that `--#{category_flags}` confuses this even more.
  3. Merge pull request #245 from issyl0/fix-formula-analytics-flags-again

    issyl0 committed Feb 6, 2020
    Fix conflicting flags in formula-analytics calls for every combination
  4. Fix conflicting flags in formula-analytics calls for every combination

    issyl0 committed Feb 6, 2020
    - This is a follow up to #244 as I missed some cases!
    - We only use `--all-core-formulae-json` for `core-build-error` etc.
      categories. There are also normal `build-error` etc. categories that
      need the plain `--json` flags.
    - This adds `--json` to the build-error flags if the existing category
      names don't have `--all-core-formulae-json` already specified. This
      seemed tidier than adding extra `when`s to the `case` statement for
      all the other categories.
  5. Merge pull request #244 from Homebrew/fix-exclusive-json-arguments

    issyl0 committed Feb 6, 2020
    The `--json` and `--all-core-formulae-json` flags are exclusive
  6. The `--json` and `--all-core-formulae-json` flags are exclusive

    issyl0 committed Feb 6, 2020
    - In Homebrew/homebrew-formula-analytics#129, `brew formula-analytics` switched to use `CLI::Parser`. While doing so, `--json` and `--all-core-formulae-json` were set to be [conflicting](https://github.com/Homebrew/homebrew-formula-analytics/blob/master/cmd/formula-analytics.rb#L34).
    - This caused an issue where the GitHub Action to generate the data for these formulae.brew.sh pages [couldn't run](Homebrew/homebrew-core#49840) because it was using both of the arguments.
    - Instead, make this only use `--all-core-formulae-json` as it's the more specific one.
You can’t perform that action at this time.