Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The `--json` and `--all-core-formulae-json` flags are exclusive #244

Merged
merged 1 commit into from Feb 6, 2020

Conversation

@issyl0
Copy link
Member

issyl0 commented Feb 6, 2020

  • In Homebrew/homebrew-formula-analytics#129, brew formula-analytics switched to use CLI::Parser. While doing so, --json and --all-core-formulae-json were set to be conflicting.
  • This caused an issue where the GitHub Action to generate the data for these formulae.brew.sh pages couldn't run because it was using both of the arguments.
  • Instead, make this only use --all-core-formulae-json as it's the more specific one.

Fixes Homebrew/homebrew-core#49840.

- In Homebrew/homebrew-formula-analytics#129, `brew formula-analytics` switched to use `CLI::Parser`. While doing so, `--json` and `--all-core-formulae-json` were set to be [conflicting](https://github.com/Homebrew/homebrew-formula-analytics/blob/master/cmd/formula-analytics.rb#L34).
- This caused an issue where the GitHub Action to generate the data for these formulae.brew.sh pages [couldn't run](Homebrew/homebrew-core#49840) because it was using both of the arguments.
- Instead, make this only use `--all-core-formulae-json` as it's the more specific one.
@issyl0 issyl0 merged commit baa3f30 into master Feb 6, 2020
1 check passed
1 check passed
tests
Details
@issyl0 issyl0 deleted the fix-exclusive-json-arguments branch Feb 6, 2020
issyl0 added a commit to issyl0/formulae.brew.sh that referenced this pull request Feb 6, 2020
- This is a follow up to Homebrew#244 as I missed some cases!
- We only use `--all-core-formulae-json` for `core-build-error` etc.
  categories. There are also normal `build-error` etc. categories that
  need the plain `--json` flags.
- This adds `--json` to the build-error flags if the existing category
  names don't have `--all-core-formulae-json` already specified. This
  seemed tidier than adding extra `when`s to the `case` statement for
  all the other categories.
issyl0 added a commit to issyl0/formulae.brew.sh that referenced this pull request Feb 6, 2020
- This is a follow up to Homebrew#244 as I missed some cases!
- We only use `--all-core-formulae-json` for `core-build-error` etc.
  categories. There are also normal `build-error` etc. categories that
  need the plain `--json` flags.
- This adds `--json` to the build-error flags if the existing category
  names don't have `--all-core-formulae-json` already specified. This
  seemed tidier than adding extra `when`s to the `case` statement for
  all the other categories.
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Feb 6, 2020

Thanks for the quick fix @issyl0 🎉

issyl0 added a commit that referenced this pull request Feb 6, 2020
- Follow up to #244.
- The confusion between what needs `--` and what doesn't strikes again!
  It doesn't help that `--#{category_flags}` confuses this even more.
@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Feb 6, 2020

A fix in three parts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.