Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix conflicting flags in formula-analytics calls for every combination #245
- This is a follow up to #244 as I missed some cases! - We only use `--all-core-formulae-json` for `core-build-error` etc. categories. There are also normal `build-error` etc. categories that need the plain `--json` flags. - This adds `--json` to the build-error flags if the existing category names don't have `--all-core-formulae-json` already specified. This seemed tidier than adding extra `when`s to the `case` statement for all the other categories.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.