Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicting flags in formula-analytics calls for every combination #245

Merged
merged 1 commit into from Feb 6, 2020

Conversation

@issyl0
Copy link
Member

issyl0 commented Feb 6, 2020

  • This is a follow up to #244 as I missed some cases!
  • We only use --all-core-formulae-json for core-build-error etc.
    categories. There are also normal build-error etc. categories that
    need the plain --json flags.
  • This adds --json to the build-error flags if the existing category
    names don't have --all-core-formulae-json already specified. This
    seemed tidier than adding extra whens to the case statement for
    all the other categories.
@issyl0 issyl0 force-pushed the issyl0:fix-formula-analytics-flags-again branch from aed65a0 to 18362de Feb 6, 2020
- This is a follow up to #244 as I missed some cases!
- We only use `--all-core-formulae-json` for `core-build-error` etc.
  categories. There are also normal `build-error` etc. categories that
  need the plain `--json` flags.
- This adds `--json` to the build-error flags if the existing category
  names don't have `--all-core-formulae-json` already specified. This
  seemed tidier than adding extra `when`s to the `case` statement for
  all the other categories.
@issyl0 issyl0 force-pushed the issyl0:fix-formula-analytics-flags-again branch from 18362de to 9755605 Feb 6, 2020
@issyl0 issyl0 merged commit 0e31cec into Homebrew:master Feb 6, 2020
1 check passed
1 check passed
tests
Details
@issyl0 issyl0 deleted the issyl0:fix-formula-analytics-flags-again branch Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.