Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split formula bottle support list into new table #408

Merged
merged 2 commits into from Jan 22, 2021
Merged

Split formula bottle support list into new table #408

merged 2 commits into from Jan 22, 2021

Conversation

EricFromCanada
Copy link
Member

Fixes #407: splits macOS bottle support list into new table with separate rows for both architectures. Also removes reference to devel.

SMillerDev
SMillerDev reviewed Jan 20, 2021
View reviewed changes
_layouts/formula.html Outdated Show resolved Hide resolved
_layouts/formula.html Show resolved Hide resolved
MikeMcQuaid
MikeMcQuaid reviewed Jan 20, 2021
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far! Stuff I'd love, if you get the chance (but feel free to push back on any of these):

  • a before/after screenshot
  • somehow providing a similar message for bottle :unneeded formula

_layouts/formula.html Outdated Show resolved Hide resolved
_layouts/formula.html Outdated Show resolved Hide resolved
@EricFromCanada
Copy link
Member Author

Before:
before

After:
after 1
after 2
after 3

MikeMcQuaid
MikeMcQuaid reviewed Jan 20, 2021
View reviewed changes
_layouts/formula.html Outdated Show resolved Hide resolved
@EricFromCanada EricFromCanada changed the title Split macOS formula bottle support list into new table Split formula bottle support list into new table Jan 21, 2021
MikeMcQuaid
MikeMcQuaid approved these changes Jan 22, 2021
View reviewed changes
_layouts/formula.html Outdated Show resolved Hide resolved
_layouts/formula.html Outdated Show resolved Hide resolved
_layouts/formula.html Outdated Show resolved Hide resolved
_layouts/formula.html Outdated Show resolved Hide resolved
@MikeMcQuaid MikeMcQuaid merged commit 064a6b6 into Homebrew:master Jan 22, 2021
@MikeMcQuaid
Copy link
Member

Thanks again @EricFromCanada, great work as usual!

@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display Apple Silicon support (or lack of support) in a clearer way
4 participants
@EricFromCanada @MikeMcQuaid @SMillerDev @BrewTestBot