Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mas app name with space can not be skipped #525

Closed
JounQin opened this issue Jul 14, 2019 · 12 comments · Fixed by #529
Closed

mas app name with space can not be skipped #525

JounQin opened this issue Jul 14, 2019 · 12 comments · Fixed by #529

Comments

@JounQin
Copy link

@JounQin JounQin commented Jul 14, 2019

For example:

export HOMEBREW_BUNDLE_MAS_SKIP="Telegram\ Desktop"
@JounQin JounQin changed the title cask name with space can not be skipped mas app name with space can not be skipped Jul 14, 2019
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jul 14, 2019

Did you try using the id instead?

@JounQin

This comment has been minimized.

Copy link
Author

@JounQin JounQin commented Jul 14, 2019

I'm using export HOMEBREW_BUNDLE_MAS_SKIP=$(brew bundle list --mas | paste -sd " " -) to generate the command automatically.

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jul 14, 2019

HOMEBREW_BUNDLE_MAS_SKIP is not HOMEBREW_BUNDLE_CASK_SKIP so what are you using?

@JounQin

This comment has been minimized.

Copy link
Author

@JounQin JounQin commented Jul 14, 2019

Sorry, I'm using them both for Linux, just copied it incorrectly.

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jul 14, 2019

A PR doing something like ��#517 (comment) is your best bet then.

@JounQin

This comment has been minimized.

Copy link
Author

@JounQin JounQin commented Jul 14, 2019

I don't understand, although I'm trying to skip to install on Linux, and it doesn't work as expected, but it should also won't work on macOS too (I tried).

So I think it's an issue with usage of HOMEBREW_BUNDLE_MAS_SKIP itself, not for Linux, this issue should not be closed.

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jul 14, 2019

Again: did you try using the id instead?

@JounQin

This comment has been minimized.

Copy link
Author

@JounQin JounQin commented Jul 14, 2019

It's generated automatically by brew bundle list --mas, I didn't find how to list ids?

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jul 15, 2019

Try the ids from brew bundle dump instead.

@JounQin

This comment has been minimized.

Copy link
Author

@JounQin JounQin commented Jul 15, 2019

I mean I want to automatically to get them into a dynamic script, is there a simple way? Sorry I'm not so good at shell script.

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jul 15, 2019

We don't support either Linux or generating them from brew bundle list --mas. Can you try the IDs manually and, if it works for you, we may adjust the behaviour accordingly.

@JounQin

This comment has been minimized.

Copy link
Author

@JounQin JounQin commented Jul 15, 2019

It seems that does not work either.

@MikeMcQuaid MikeMcQuaid reopened this Jul 16, 2019
MikeMcQuaid added a commit to MikeMcQuaid/homebrew-bundle that referenced this issue Jul 17, 2019
This will allow skipping `mas` apps with spaces in the name.

Fixes Homebrew#525.
MikeMcQuaid added a commit to MikeMcQuaid/homebrew-bundle that referenced this issue Jul 17, 2019
This will allow skipping `mas` apps with spaces in the name.

Fixes Homebrew#525.
MikeMcQuaid added a commit to MikeMcQuaid/homebrew-bundle that referenced this issue Jul 17, 2019
This will allow skipping `mas` apps with spaces in the name.

Fixes Homebrew#525.
@jamesstidard jamesstidard mentioned this issue Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.