Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Oracle JDK 8 update 202 #6934

Merged
merged 2 commits into from Feb 4, 2019

Conversation

@Enrico204
Copy link
Contributor

commented Feb 3, 2019

Added Oracle JDK 8 (update 202).

Note that java8 is broken now, so maybe it should be removed. However, I named this oracle-jdk8 because java8 was under the name "OpenJDK" and instead is the "Oracle distribution of Java 8". Unfortunately, JDK 8 is not available anymore (see https://jdk.java.net/8/ and issue Homebrew/homebrew-cask#58311 )

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.
  • The submission is for a stable version or documented exception.

Additionally, if adding a new cask:

@Enrico204 Enrico204 referenced this pull request Feb 3, 2019
10 of 10 tasks complete
@ojizero
ojizero approved these changes Feb 3, 2019
Copy link

left a comment

LGTM

@reitermarkus

This comment has been minimized.

Copy link
Member

commented Feb 3, 2019

Since the java8 cask is broken and this is the only version left (according to
Homebrew/homebrew-cask#58311 (comment)), this should probably replace java8 instead.

@Enrico204

This comment has been minimized.

Copy link
Contributor Author

commented Feb 3, 2019

Shall I modify this PR or create a new one?

@reitermarkus

This comment has been minimized.

Copy link
Member

commented Feb 3, 2019

@Enrico204, whatever is easier for you.

@msdos

This comment has been minimized.

Copy link

commented Feb 4, 2019

I just did a brew cask edit java8 and pasted the file presented in 7533473. It works. Thanks for this fix.

shulyugin added a commit to tigrannajaryan/made-frontend that referenced this pull request Feb 4, 2019
shulyugin added a commit to tigrannajaryan/made-frontend that referenced this pull request Feb 4, 2019

@reitermarkus reitermarkus merged commit 01b8a79 into Homebrew:master Feb 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vitorgalvao vitorgalvao referenced this pull request Feb 6, 2019
7 of 7 tasks complete

@lock lock bot added the outdated label Mar 6, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Mar 6, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.