Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ilspy: add arm version #151928

Merged
merged 1 commit into from
Aug 3, 2023
Merged

ilspy: add arm version #151928

merged 1 commit into from
Aug 3, 2023

Conversation

benediktwerner
Copy link
Contributor

No description provided.

@request-info
Copy link

request-info bot commented Jul 28, 2023

The maintainers of this repository would appreciate it if you could provide more information.

@benediktwerner benediktwerner marked this pull request as draft July 28, 2023 23:17
@benediktwerner benediktwerner marked this pull request as ready for review July 28, 2023 23:44
@benediktwerner
Copy link
Contributor Author

The /usr/bin/xattr -rd com.apple.quarantine /Applications/ILSpy.app call is required for some reason, otherwise MacOS reports the app as broken and suggests moving it to the trash: icsharpcode/AvaloniaILSpy#63

The chmod suggested in the issue wasn't necessary for me though.

@bevanjkay
Copy link
Member

@benediktwerner We do not support the removal of the quarantine attributes. In fact, we have gone to great lengths to support it as it is a valuable security feature.

If the application is not functional without we may need to reject the addition of the cask at this stage.

@bevanjkay bevanjkay added the awaiting user reply Issue needs response from a user. label Jul 30, 2023
@benediktwerner
Copy link
Contributor Author

Hm, I see, I removed that part again but it's definitely not functional without it. I realized later, that there is a --no-quarantine flag which also makes it work. Is that fine or does it need to work without that?

@SMillerDev
Copy link
Member

If it doesn't work without it it means the app is not properly signed and will cause issues on ARM.

@miccal miccal merged commit 2aa58f8 into Homebrew:master Aug 3, 2023
7 checks passed
@miccal
Copy link
Member

miccal commented Aug 3, 2023

Thank you @benediktwerner.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting user reply Issue needs response from a user. outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants