Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Studio Link Plugin v15.12.1-beta #16290

Closed
wants to merge 1 commit into from
Closed

Add Studio Link Plugin v15.12.1-beta #16290

wants to merge 1 commit into from

Conversation

lukasbestle
Copy link
Contributor

No description provided.

vitorgalvao
vitorgalvao reviewed Jan 3, 2016
View reviewed changes
Casks/studio-link-plugin.rb
version '15.12.1-beta'
sha256 '12145c5d054527a1460038166f5cf2d18219e3b614e01391af9b8b6d7a3d765f'

url "https://github.com/Studio-Link-v2/backend/releases/download/#{version}/studio-link-osx.zip"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a appcast 'https://github.com/Studio-Link-v2/backend/releases.atom' line under.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, please point to where on the website you found the download link.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a # github.com is the official download host per the vendor homepage comment above this line (example; reasoning).

@lukasbestle
Copy link
Contributor Author

Thanks for the feedback. I just added the missing lines and squashed my commits.

Since the plugin is currently in beta, the documentation and download link is not already on the main site but on a subdomain.

@vitorgalvao
Copy link
Member

Since the plugin is currently in beta, the documentation and download link is not already on the main site but on a subdomain.

Ah, we should use that for now, then.

@vitorgalvao
Copy link
Member

Thank you for the contribution. It needed some fixes, so they were made in b6e6c95. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.

@vitorgalvao vitorgalvao closed this Jan 3, 2016
@lukasbestle lukasbestle deleted the patch-2 branch January 3, 2016 17:57
@lukasbestle
Copy link
Contributor Author

Thanks! Looks good.

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasbestle @vitorgalvao