-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
cables 0.2.0 (new cask) #181742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cables 0.2.0 (new cask) #181742
Conversation
khipp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the submission, @lusimeon! I left a few suggestions below.
As for the notability audit, it seems like an established product that has been used in schools and universities. So, I would be happy to approve this.
|
Thank you for your constructive feedback. I have the feeling that the project is making a transition from the name "cables.gl" to "cables", so it makes more sense to define the cask as "cables" 😉 |
khipp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.GitHub repository not notable enoughthrown as the project has only been open-sourced since few days.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.Description
Add formulae for https://github.com/cables-gl/cables_electron (https://cables.gl/standalone).