Skip to content

Conversation

@lusimeon
Copy link
Contributor

@lusimeon lusimeon commented Aug 6, 2024

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
    • The error GitHub repository not notable enough thrown as the project has only been open-sourced since few days.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Description

Add formulae for https://github.com/cables-gl/cables_electron (https://cables.gl/standalone).

Low-code, browser-based visual programming tool for creating real-time generative and interactive content

Copy link
Member

@khipp khipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the submission, @lusimeon! I left a few suggestions below.

As for the notability audit, it seems like an established product that has been used in schools and universities. So, I would be happy to approve this.

@khipp khipp changed the title cables.gl 0.2.0 (new cask) cables 0.2.0 (new cask) Aug 7, 2024
@khipp khipp added the ci-skip-repository Skip repository checks on CI. Use only after repository has been verified manually. label Aug 7, 2024
@lusimeon
Copy link
Contributor Author

lusimeon commented Aug 7, 2024

Thank you for your constructive feedback. I have the feeling that the project is making a transition from the name "cables.gl" to "cables", so it makes more sense to define the cask as "cables" 😉

Copy link
Member

@khipp khipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@p-linnane p-linnane enabled auto-merge August 7, 2024 17:12
@p-linnane p-linnane merged commit de36a59 into Homebrew:master Aug 7, 2024
@lusimeon lusimeon deleted the add-cables-gl branch August 7, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-skip-repository Skip repository checks on CI. Use only after repository has been verified manually. new cask

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants