Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cask for hab #21977

Merged
merged 1 commit into from Jun 15, 2016
Merged

add cask for hab #21977

merged 1 commit into from Jun 15, 2016

Conversation

@cullenmcdermott
Copy link
Contributor

@cullenmcdermott cullenmcdermott commented Jun 15, 2016

Adding a new cask

  • [] Checked there aren’t open pull requests for the same cask.
  • [] Checked there aren’t closed issues where that cask was already refused.
  • [] When naming the cask, followed the token reference.
  • [] Commit message includes cask’s name.
  • [] brew cask audit --download {{cask_file}} is error-free.
  • [] brew cask style --fix {{cask_file}} left no offenses.
  • [] brew cask install {{cask_file}} worked successfully.
  • [] brew cask uninstall {{cask_file}} worked successfully.
@vitorgalvao
Copy link
Member

@vitorgalvao vitorgalvao commented Jun 15, 2016

Thank you for the contribution. Seems like this is an open-source CLI tool. In that case, and to avoid duplication this should be only in homebrew.

I saw Homebrew/homebrew-core#1994, but this should be reworked as a formula that is compiled, rather than a downloadable cask.

Pinging @DomT4.

@cullenmcdermott
Copy link
Contributor Author

@cullenmcdermott cullenmcdermott commented Jun 15, 2016

Yeah that was my initial plan but Habitat has some dependencies on on the casks vmware-fusion and dockertoolbox in order to compile it from source and I wasn't able to find a good way to depend on a cask from inside of a formula. I'll look into it some more.

@DomT4
Copy link
Member

@DomT4 DomT4 commented Jun 15, 2016

@vitorgalvao Hey Vitor. My message about the Cask accepting binaries is a generic reply, to be honest. I'm happy to poke people towards homebrew/binary instead if Cask wants to completely avoid CLI stuff going forwards?

If it can build from source & someone's willing to work on that we're certainly happy to take it in homebrew/core, but I wasn't sure if that was the case here.

@vitorgalvao
Copy link
Member

@vitorgalvao vitorgalvao commented Jun 15, 2016

I'm happy to poke people towards homebrew/binary instead if Cask wants to completely avoid CLI stuff going forwards?

We’re happy to take CLI stuff, it just seemed to me that since this is open-source and CLI-only, homebrew-core would be the better place.

but Habitat has some dependencies on on the casks vmware-fusion and dockertoolbox in order to compile it from source and I wasn't able to find a good way to depend on a cask from inside of a formula.

If there’s such a hurdle in getting this to compile from source, then sure, we’ll take it here.

If it can build from source & someone's willing to work on that we're certainly happy to take it in homebrew/core, but I wasn't sure if that was the case here.

If that happens, then we can switch (remove from HBC, add to HB).

@vitorgalvao vitorgalvao reopened this Jun 15, 2016
version '0.6.0-20160613151520'
sha256 '2251891c376bd3786a2c8242006367a3fd9f896cab850472c73886c6556598d1'

# bintray is where the habitat binaries are stored

This comment has been minimized.

@vitorgalvao

vitorgalvao Jun 15, 2016
Member

Comment needs to be reworked. Can you show me where on the official websites do they link to this URL? I need to verify it.

This comment has been minimized.

@cullenmcdermott

cullenmcdermott Jun 15, 2016
Author Contributor

Here is the page where they link to it: https://www.habitat.sh/docs/get-habitat/

How should it be reworded?

sha256 '2251891c376bd3786a2c8242006367a3fd9f896cab850472c73886c6556598d1'

# bintray is where the habitat binaries are stored
url "https://api.bintray.com/content/habitat/stable/darwin/x86_64/hab-#{version}-x86_64-darwin.zip?bt_package=hab-x86_64-darwin"

This comment has been minimized.

@vitorgalvao

vitorgalvao Jun 15, 2016
Member

Can’t the ?bt_package=hab-x86_64-darwin part be removed?

version '0.7.0-20160614231131'
sha256 '93fac880261df34c75ac5775c9febb536b82ac955cd6df873bbfec1cf697ed50'

# bintray is where the habitat binaries are stored

This comment has been minimized.

@vitorgalvao

vitorgalvao Jun 15, 2016
Member

Should be # habitat.bintray.com was verified as official when first introduced to the cask (example; reasoning).

@vitorgalvao vitorgalvao merged commit db784c9 into Homebrew:master Jun 15, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@DomT4 DomT4 mentioned this pull request Jun 15, 2016
4 of 4 tasks complete
@cullenmcdermott cullenmcdermott deleted the cullenmcdermott:hab branch Jun 16, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants