Skip to content

add cask for hab#21977

Merged
vitorgalvao merged 1 commit intoHomebrew:masterfrom
cullenmcdermott:hab
Jun 15, 2016
Merged

add cask for hab#21977
vitorgalvao merged 1 commit intoHomebrew:masterfrom
cullenmcdermott:hab

Conversation

@cullenmcdermott
Copy link
Copy Markdown

Adding a new cask

  • [✅] Checked there aren’t open pull requests for the same cask.
  • [✅] Checked there aren’t closed issues where that cask was already refused.
  • [✅] When naming the cask, followed the token reference.
  • [✅] Commit message includes cask’s name.
  • [✅] brew cask audit --download {{cask_file}} is error-free.
  • [✅] brew cask style --fix {{cask_file}} left no offenses.
  • [✅] brew cask install {{cask_file}} worked successfully.
  • [✅] brew cask uninstall {{cask_file}} worked successfully.

@vitorgalvao
Copy link
Copy Markdown
Contributor

Thank you for the contribution. Seems like this is an open-source CLI tool. In that case, and to avoid duplication this should be only in homebrew.

I saw Homebrew/homebrew-core#1994, but this should be reworked as a formula that is compiled, rather than a downloadable cask.

Pinging @DomT4.

@cullenmcdermott
Copy link
Copy Markdown
Author

Yeah that was my initial plan but Habitat has some dependencies on on the casks vmware-fusion and dockertoolbox in order to compile it from source and I wasn't able to find a good way to depend on a cask from inside of a formula. I'll look into it some more.

@DomT4
Copy link
Copy Markdown
Contributor

DomT4 commented Jun 15, 2016

@vitorgalvao Hey Vitor. My message about the Cask accepting binaries is a generic reply, to be honest. I'm happy to poke people towards homebrew/binary instead if Cask wants to completely avoid CLI stuff going forwards?

If it can build from source & someone's willing to work on that we're certainly happy to take it in homebrew/core, but I wasn't sure if that was the case here.

@vitorgalvao
Copy link
Copy Markdown
Contributor

I'm happy to poke people towards homebrew/binary instead if Cask wants to completely avoid CLI stuff going forwards?

We’re happy to take CLI stuff, it just seemed to me that since this is open-source and CLI-only, homebrew-core would be the better place.

but Habitat has some dependencies on on the casks vmware-fusion and dockertoolbox in order to compile it from source and I wasn't able to find a good way to depend on a cask from inside of a formula.

If there’s such a hurdle in getting this to compile from source, then sure, we’ll take it here.

If it can build from source & someone's willing to work on that we're certainly happy to take it in homebrew/core, but I wasn't sure if that was the case here.

If that happens, then we can switch (remove from HBC, add to HB).

@vitorgalvao vitorgalvao reopened this Jun 15, 2016
Comment thread Casks/hab.rb Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment needs to be reworked. Can you show me where on the official websites do they link to this URL? I need to verify it.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the page where they link to it: https://www.habitat.sh/docs/get-habitat/

How should it be reworded?

@vitorgalvao vitorgalvao added the awaiting user reply Issue needs response from a user. label Jun 15, 2016
Comment thread Casks/hab.rb Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be # habitat.bintray.com was verified as official when first introduced to the cask (example; reasoning).

@vitorgalvao vitorgalvao merged commit db784c9 into Homebrew:master Jun 15, 2016
@cullenmcdermott cullenmcdermott deleted the hab branch June 16, 2016 15:21
@adidalal adidalal removed the awaiting user reply Issue needs response from a user. label Jul 2, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants