New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete exceptions from homebrew-fork #22574

Merged
merged 2 commits into from Jul 5, 2016

Conversation

Projects
None yet
5 participants
@AnastasiaSulyagina
Copy link
Contributor

AnastasiaSulyagina commented Jul 4, 2016

Changes to the core

Using exceptions from homebrew now as a preparation to core merge(#14384).

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Jul 4, 2016

👏 It's also worth noting that when Homebrew/brew#390 is merged we'll be verifying that Homebrew's core changes don't end up breaking brew cask which means it'll be safer to rely on Homebrew's internals.

Rakefile Outdated
@@ -3,6 +3,7 @@ require 'rake/testtask'
require 'rspec/core/rake_task'
require 'rubocop/rake_task'

$LOAD_PATH.unshift(File.expand_path('../../../../Homebrew', __FILE__))

This comment has been minimized.

@jawshooah

jawshooah Jul 4, 2016

Contributor

There's no guarantee that tests are being run from the tap repo. For example, I have a separate clone in a common directory for Git projects where I do most of my development, so this wouldn't work for me.

Better, I think, to do this:

homebrew_repo = `brew --repository`
$LOAD_PATH.unshift(File.expand_path("#{homebrew_repo}/Library/Homebrew"))
@@ -2,6 +2,9 @@
require 'rspec/its'
require 'rspec/wait'

homebrew_library_path = Pathname.new(File.expand_path(__FILE__+'/../../../../../Homebrew'))

This comment has been minimized.

@jawshooah

jawshooah Jul 4, 2016

Contributor

Same problem here

@@ -2,6 +2,9 @@
require 'bundler/setup'
require 'pathname'

homebrew_library_path = Pathname.new(File.expand_path(__FILE__+'/../../../../../Homebrew'))

This comment has been minimized.

@jawshooah

jawshooah Jul 4, 2016

Contributor

And here

@fanquake fanquake added the core label Jul 4, 2016

@fanquake fanquake changed the title delete exceptions from homebrew-fork Delete exceptions from homebrew-fork Jul 4, 2016

@jawshooah jawshooah merged commit fe4dc6f into Homebrew:master Jul 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jawshooah

This comment has been minimized.

Copy link
Contributor

jawshooah commented Jul 5, 2016

Great work, thanks!

@AnastasiaSulyagina AnastasiaSulyagina deleted the AnastasiaSulyagina:exceptions-deletion branch Jul 5, 2016

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.