added an OpenSource MacOSX iBeacon scanner clic3r and Jitouch #4122

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@falkorichter
Contributor

falkorichter commented Apr 30, 2014

No description provided.

@falkorichter

This comment has been minimized.

Show comment
Hide comment
@falkorichter

falkorichter Apr 30, 2014

Contributor

Also added 2 others casks that I had laying around.

Contributor

falkorichter commented Apr 30, 2014

Also added 2 others casks that I had laying around.

@vitorgalvao

This comment has been minimized.

Show comment
Hide comment
@vitorgalvao

vitorgalvao Apr 30, 2014

Member

Please submit separate pull requests for each cask, as more often than not this type of pull request brings problems with one or more of them, and it halts the inclusion of the other ones. I’ll comment on each one with the needed fixes.

Member

vitorgalvao commented Apr 30, 2014

Please submit separate pull requests for each cask, as more often than not this type of pull request brings problems with one or more of them, and it halts the inclusion of the other ones. I’ll comment on each one with the needed fixes.

+ sha256 '8ab7369e67f5972da8b2df20685e9ccbc29275de8e81b986ac92ea4c518217fe'
+ prefpane 'jitouch/Jitouch.prefPane'
+end
+

This comment has been minimized.

@vitorgalvao

vitorgalvao Apr 30, 2014

Member

Extraneous line.

@vitorgalvao

vitorgalvao Apr 30, 2014

Member

Extraneous line.

@@ -0,0 +1,8 @@
+

This comment has been minimized.

@vitorgalvao

vitorgalvao Apr 30, 2014

Member

Extraneous line.

@vitorgalvao

vitorgalvao Apr 30, 2014

Member

Extraneous line.

+class Jitouch < Cask
+ url 'http://www.jitouch.com/jitouch_mavericks.zip'
+ homepage 'http://www.jitouch.com'
+ version '2.53'

This comment has been minimized.

@vitorgalvao

vitorgalvao Apr 30, 2014

Member

Seeing as url doesn’t point to a specific version, this cask should use version 'latest' and no_checksum. See an example.

@vitorgalvao

vitorgalvao Apr 30, 2014

Member

Seeing as url doesn’t point to a specific version, this cask should use version 'latest' and no_checksum. See an example.

@falkorichter falkorichter changed the title from added an OpenSource MacOSX iBeacon scanner to added an OpenSource MacOSX iBeacon scanner clic3r and Jitouch Apr 30, 2014

@@ -0,0 +1,7 @@
+class Beaconscanner < Cask

This comment has been minimized.

@vitorgalvao

vitorgalvao Apr 30, 2014

Member

As per the naming reference, the file should be named beacon-scanner.rb with class BeaconScanner.

@vitorgalvao

vitorgalvao Apr 30, 2014

Member

As per the naming reference, the file should be named beacon-scanner.rb with class BeaconScanner.

@falkorichter falkorichter referenced this pull request in mlwelles/BeaconScanner Apr 30, 2014

Closed

use github releases #2

@falkorichter

This comment has been minimized.

Show comment
Hide comment
@falkorichter

falkorichter May 1, 2014

Contributor

All Right, I´ll close this pull request and start individual ones for each cask

Contributor

falkorichter commented May 1, 2014

All Right, I´ll close this pull request and start individual ones for each cask

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.