New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ResidualVM v0.3.0 #42536

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@epistrephein
Copy link
Contributor

epistrephein commented Jan 5, 2018

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.
@vitorgalvao
Copy link
Member

vitorgalvao left a comment

Edit: made in error.

@commitay commitay force-pushed the epistrephein:residualvm branch to b9af48e Jan 6, 2018

name 'ResidualVM'
homepage 'http://www.residualvm.org/'

depends_on macos: '>= :high_sierra'

This comment has been minimized.

@commitay

commitay Jan 6, 2018

Contributor

Why High Sierra?

The intel 64 dmg is for 10.7+
http://www.residualvm.org/downloads/

This comment has been minimized.

@vitorgalvao

vitorgalvao Jan 6, 2018

Member

The intel 64 dmg is for 10.7+

It says that on the website, but when I downloaded (to check for an appcast — it exists, but goes somewhere the server does not allow) it showed the icon with the prohibition icon on top, so this might be right (I’m on Sierra).

This comment has been minimized.

@commitay

commitay Jan 6, 2018

Contributor

Doesn't seem to work on High Sierra, same message in VM and host.

residualvm

@commitay

This comment has been minimized.

Copy link
Contributor

commitay commented Jan 6, 2018

possible duplicate, cask token conflicts with Homebrew core formula: https://github.com/Homebrew/homebrew-core/blob/master/Formula/residualvm.rb
@epistrephein

This comment has been minimized.

Copy link
Contributor

epistrephein commented Jan 6, 2018

Definitely looks like the OSX build is broken.
I wasn't sure about the 10.7+ system requirement on the website since on my Sierra didn't work, but I've tested on two High Sierra and I can confirm it doesn't work.
I'll open an issue on their repo and report back here if that's ok.

About duplication, I think residualvm would work just like scummvm: build from source (brew) or install the app (cask).

@commitay

This comment has been minimized.

Copy link
Contributor

commitay commented Jan 6, 2018

About duplication ...

The duplication is okay as they provide different things, I just added the comment as a note to show that it was known when it was merged.

I'll open an issue on their repo and report back here it that's ok.

Great, thanks!

@commitay

This comment has been minimized.

Copy link
Contributor

commitay commented Feb 13, 2018

Closing for now as it's been over a month and upstream haven't responded.

Feel feel to open a new PR when upstream has the app is working.

@commitay commitay closed this Feb 13, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 14, 2018

@epistrephein epistrephein deleted the epistrephein:residualvm branch Jan 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.