New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore phantomjs #52595

Merged
merged 3 commits into from Oct 3, 2018

Conversation

Projects
None yet
8 participants
@bval
Contributor

bval commented Sep 28, 2018

phantomjs can no longer be built by homebrew as a dependency, qt@5.5, no longer builds on MacOS X 10.14 Mojave. Homebrew/homebrew-core#32402 suggests removing it and migrating back to the Cask. This PR supports that recommendation. A separate PR to homebrew-core will add this Cask to the tap_migrations.json for core.

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.
  • The submission is for a stable version or documented exception.
@bval

This comment has been minimized.

Contributor

bval commented Sep 28, 2018

CI is only failing because it checks for duplicates in homebrew-core, where one will still exist until this can be merged and the core formula removed.

@bval bval referenced this pull request Sep 28, 2018

Closed

phantomjs: remove and migrate to cask #32538

4 of 4 tasks complete
@vitorgalvao

This comment has been minimized.

Member

vitorgalvao commented Sep 28, 2018

Phantomjs is abandoned software. We don’t really like keeping those. You may wish to consider hosting your own tap for it.

@fxcoudert

This comment has been minimized.

Member

fxcoudert commented Sep 28, 2018

The reason we suggested moving it to cask is that it has a large user base (4,870 installs per month) from Homebrew core. Yet we can't keep it in core since it doesn't build from source anymore on High Sierra and Mojave.

If you don't want it in cask, I see no other option that to remove it altogether from core anyway… but I wish we had a better option. I know it's not actively maintained, but it does work.

@vitorgalvao vitorgalvao reopened this Sep 28, 2018

@vitorgalvao vitorgalvao requested a review from Homebrew/cask Sep 28, 2018

@fxcoudert

This comment has been minimized.

Member

fxcoudert commented Oct 2, 2018

@vitorgalvao @adidalal waiting on this one to merge Homebrew/homebrew-core#32538

@vitorgalvao

This comment has been minimized.

Member

vitorgalvao commented Oct 2, 2018

@fxcoudert I’m neutral leaning on refusal, so I’d like a few more maintainer opinions beforehand. Ping @Homebrew/cask.

@reitermarkus

This comment has been minimized.

Member

reitermarkus commented Oct 2, 2018

I'm also neutral, but it should have a discontinued caveat.

@bval

This comment has been minimized.

Contributor

bval commented Oct 2, 2018

I'm also neutral, but it should have a discontinued caveat.

Thanks! This is my first Cask PR. TIL about that caveat. Added.

@amyspark

Can't really complain. 👍

@commitay commitay merged commit d2314d6 into Homebrew:master Oct 3, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@bval bval deleted the bval:restore-phantomjs branch Oct 4, 2018

@lock lock bot locked and limited conversation to collaborators Nov 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.