Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp reporting bugs docs #57844

Merged
merged 11 commits into from Jan 24, 2019

Conversation

Projects
None yet
2 participants
@vitorgalvao
Copy link
Member

vitorgalvao commented Jan 23, 2019

The eternal struggle to make the reporting bugs docs read and understood by more users. This is part of a process of changing the error messages on the core to link directly to these fixes, instead of general bug reports.

@vitorgalvao vitorgalvao requested a review from Homebrew/cask Jan 23, 2019

@vitorgalvao vitorgalvao referenced this pull request Jan 23, 2019

Merged

CaskSha256MismatchError: link to fix #5595

3 of 6 tasks complete
@vitorgalvao

This comment has been minimized.

Copy link
Member Author

vitorgalvao commented Jan 23, 2019

First suggestion to the core, incorporating this: Homebrew/brew#5595

@claui
Copy link
Member

claui left a comment

While we’re touching the docs, maybe iron out a few small bumps in the copy.

Show resolved Hide resolved doc/reporting_bugs/permission_denied_error.md Outdated
Show resolved Hide resolved doc/reporting_bugs/checksum_does_not_match_error.md Outdated
Show resolved Hide resolved doc/reporting_bugs/checksum_does_not_match_error.md Outdated
Show resolved Hide resolved doc/reporting_bugs/curl_error.md Outdated
Show resolved Hide resolved doc/reporting_bugs/curl_error.md Outdated
Show resolved Hide resolved doc/reporting_bugs/curl_error.md Outdated
Show resolved Hide resolved doc/reporting_bugs/error_examples.md Outdated
Show resolved Hide resolved doc/reporting_bugs/source_is_not_there_error.md Outdated

claui and others added some commits Jan 23, 2019

Update doc/reporting_bugs/permission_denied_error.md
Co-Authored-By: vitorgalvao <info@vitorgalvao.com>
Update doc/reporting_bugs/checksum_does_not_match_error.md
Co-Authored-By: vitorgalvao <info@vitorgalvao.com>
Update doc/reporting_bugs/curl_error.md
Co-Authored-By: vitorgalvao <info@vitorgalvao.com>
Update doc/reporting_bugs/curl_error.md
Co-Authored-By: vitorgalvao <info@vitorgalvao.com>
Update doc/reporting_bugs/error_examples.md
Co-Authored-By: vitorgalvao <info@vitorgalvao.com>
Update doc/reporting_bugs/checksum_does_not_match_error.md
Co-Authored-By: vitorgalvao <info@vitorgalvao.com>
@claui

claui approved these changes Jan 23, 2019

Copy link
Member

claui left a comment

LGTM now 👍

@vitorgalvao

This comment has been minimized.

Copy link
Member Author

vitorgalvao commented Jan 23, 2019

Thank you for the fixes, @claui!

@vitorgalvao vitorgalvao merged commit 67cf535 into master Jan 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vitorgalvao vitorgalvao deleted the reporting-bugs branch Jan 24, 2019

@lock lock bot added the outdated label Feb 23, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Feb 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.