Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -app suffix rule #59689

Merged
merged 17 commits into from Mar 11, 2019
Merged

Remove -app suffix rule #59689

merged 17 commits into from Mar 11, 2019

Conversation

@vitorgalvao
Copy link
Member

@vitorgalvao vitorgalvao commented Mar 2, 2019

Refs Homebrew/brew#5724 (comment).

I’ll still open an issue regarding what needs to be discussed from there, but this could already be a PR: get rid of the -app suffix rule. It was a well intentioned rule that did its job during the deduplication effort, but now its just confusing. We should focus on the CLI/GUI difference between HB/HBC.

I’ve also removed two of those casks that were unpopular:

corectl-app (added 821 days ago)
30 days: 4 (#2934)
90 days: 19 (#2561)
365 days: 31 (#2811)

mediaconch-app (added 821 days ago)
30 days: 1 (#4917)
90 days: 7 (#3896)
365 days: 17 (#3702)
@vitorgalvao vitorgalvao requested a review from Homebrew/cask Mar 2, 2019
@vitorgalvao vitorgalvao merged commit 9e6c0ec into master Mar 11, 2019
1 of 5 checks passed
1 of 5 checks passed
@github-actions
automerge automerge
Details
@github-actions
automerge automerge
Details
@github-actions
automerge automerge
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@github-actions
master master
Details
@vitorgalvao vitorgalvao deleted the no-app-suffix branch Mar 11, 2019
yihui added a commit to yihui/homebrew-cran-extra that referenced this pull request Mar 13, 2019
@lock lock bot added the outdated label Apr 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant