Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoomus: kill and remove persistent webserver #65968

Merged
merged 8 commits into from Jul 9, 2019

Conversation

Projects
None yet
2 participants
@cblecker
Copy link
Contributor

commented Jul 9, 2019

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.
  • The submission is for a stable version or documented exception.

Remove persistent webserver that's installed along with Zoom when uninstalling.

ref: https://medium.com/@jonathan.leitschuh/zoom-zero-day-4-million-webcams-maybe-an-rce-just-get-them-to-visit-your-website-ac75c83f4ef5

cblecker and others added some commits Jul 9, 2019

@vitorgalvao

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Thank you for this. I came here to add it; good to see someone else had already started it.

The current quit/kill code was already enough to stop the webserver from running. We were only missing login_item and trashing .zoomus.

vitorgalvao added some commits Jul 9, 2019

@vitorgalvao

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Having a broken style locally is really making this hard! Let’s hope this is it.

@vitorgalvao vitorgalvao merged commit 175d46d into Homebrew:master Jul 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cblecker cblecker deleted the cblecker:zoomus branch Jul 9, 2019

@cblecker

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

@vitorgalvao Thanks for carrying the changes and getting this in ASAP!

@vitorgalvao

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

I’d have done it sooner, but I was asleep!

@tomyun tomyun referenced this pull request Jul 9, 2019

Merged

Update zoomus to 4.4.53932.0709 #66034

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.