New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating owncloud #7278

Merged
merged 1 commit into from Nov 13, 2014

Conversation

Projects
None yet
3 participants
@laurentperrinet
Contributor

laurentperrinet commented Nov 12, 2014

OwnCloud was updated to 1.7 on Nov 11th.

@tapeinosyne

This comment has been minimized.

Contributor

tapeinosyne commented Nov 12, 2014

If the application is now distributed as a pkg, the cask needs to be updated accordingly. Would you like to do it?

@laurentperrinet

This comment has been minimized.

Contributor

laurentperrinet commented Nov 12, 2014

Ok updated by using the pkg stanza instead of app.

@vitorgalvao

This comment has been minimized.

Member

vitorgalvao commented Nov 12, 2014

It’s also missing uninstall. There are scripts and documentation geared for that. Do you need any help?

@laurentperrinet

This comment has been minimized.

Contributor

laurentperrinet commented Nov 12, 2014

Certainly, it seems I would need help :-)
If you are ok with my incremental approach in this branch, I'm happy to learn!
cheers

@vitorgalvao

This comment has been minimized.

Member

vitorgalvao commented Nov 12, 2014

Naturally. We only ask that you squash your commits after (that is a process that trips up a lot of beginners, so if you’re feeling insecure with the instructions, just let us know and we can do it for you). It’s always great to see contributors wanting to make the corrections.

It seems fine now, though, you appear to have handled uninstall correctly. There’s only a small change we should make. Instead of:

uninstall :pkgutil => 'com.ownCloud.client'
uninstall :pkgutil => 'com.owncCloud.finderPlugin'

We prefer it as:

uninstall :pkgutil => [
                       'com.ownCloud.client',
                       'com.owncCloud.finderPlugin',
                      ]

Otherwise, it is absolutely fine.

@laurentperrinet

This comment has been minimized.

Contributor

laurentperrinet commented Nov 13, 2014

ok, I am trying that... thanks for your patience!
When I do

git rebase -i owncloud

git shows noopinstead of a list of commits. Should I pick up the oldest and squash others, or reverse?

@vitorgalvao

This comment has been minimized.

Member

vitorgalvao commented Nov 13, 2014

First, make sure you’re on the correct branch (git checkout owncloud). Next, run an interactive rebase with git rebase -i head~5 (5 because you want to see the last five commits). On the file that opens, change all but the first from pick to fixup (or f, for short). Save the file, and push the branch again (you’ll need to use git push -f to force the push).

@laurentperrinet

This comment has been minimized.

Contributor

laurentperrinet commented Nov 13, 2014

ok, done. I missed the -i head~5 part in the documentation. everything seems fine by now.

@vitorgalvao

This comment has been minimized.

Member

vitorgalvao commented Nov 13, 2014

It looks great. Thank you for your patience and continued work on this. Merged.

vitorgalvao added a commit that referenced this pull request Nov 13, 2014

@vitorgalvao vitorgalvao merged commit de57d9c into Homebrew:master Nov 13, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details
Updating owncloud
OwnCloud was updated to 1.7 on Nov 11th.

@laurentperrinet laurentperrinet deleted the laurentperrinet:owncloud branch Nov 13, 2014

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.