Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git 2.13.3 and up: missing diff-highlight #15588

Closed
ghostbar opened this issue Jul 13, 2017 · 4 comments
Closed

git 2.13.3 and up: missing diff-highlight #15588

ghostbar opened this issue Jul 13, 2017 · 4 comments

Comments

@ghostbar
Copy link
Contributor

After updating git diff-highlight is no longer available.

git 2.13.2:

$ ls /usr/local/opt/git/share/git-core/contrib/diff-highlight/
t  Makefile  README  diff-highlight

git 2.13.3 and git HEAD:

$ ls /usr/local/opt/git/share/git-core/contrib/diff-highlight/
t  DiffHighlight.pm  Makefile  README  diff-highlight.perl
@ilovezfs
Copy link
Contributor

 make -C $(brew --prefix git)/share/git-core/contrib/diff-highlight

@ghostbar
Copy link
Contributor Author

Maybe this should be added to the formula, right? You can't expect people to run this every single time git is updated.

@ilovezfs
Copy link
Contributor

@ghostbar it's only in contrib so I'm not sure it makes sense to add that step to the formula permanently.

@ghostbar
Copy link
Contributor Author

I saw this because I depend on it, and searching on google for "diff-highlight homebrew" it seems lot of people would be expecting it to be there already compiled.

Robpol86 added a commit to Robpol86/dotfiles that referenced this issue Jul 29, 2017
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants