-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rubberband 3.1.0 #112467
rubberband 3.1.0 #112467
Conversation
Previous attempt -- #112048. MacOS's I don't think we want to make OpenJDK a dependency as it should be an optional feature. |
We should patch out the Java check and report the bug to Meson, I think. |
Someone opened a Meson issue relating to this: mesonbuild/meson#10900 May also want to see if Rubberband is willing to add Meson option to manually disable JNI feature so that we can avoid feature getting enabled if build system has OpenJDK installed. |
Alternatively, if there is no linkage, we could make |
Could make the build dependency macOS-only. |
I also don't see linkage for JNI on Linux, so could make build-only. We originally packaged Linux with $ ldd /home/linuxbrew/.linuxbrew/Cellar/rubberband/3.1.0/lib/librubberband-jni.so
libfftw3.so.3 => /home/linuxbrew/.linuxbrew/opt/fftw/lib/libfftw3.so.3 (0x000000400189c000)
libsamplerate.so.0 => /home/linuxbrew/.linuxbrew/opt/libsamplerate/lib/libsamplerate.so.0 (0x0000004001c00000)
libstdc++.so.6 => /home/linuxbrew/.linuxbrew/opt/gcc/lib/gcc/current/libstdc++.so.6 (0x00000040020ef000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x0000004002368000)
libgcc_s.so.1 => /home/linuxbrew/.linuxbrew/opt/gcc/lib/gcc/current/libgcc_s.so.1 (0x000000400244f000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x0000004002472000)
/lib64/ld-linux-x86-64.so.2 (0x0000004000000000) |
Unrelated to this PR but
|
None of failures seem related. Catalina failure on download failure. Do we not have any retries for CI to avoid sporadic failures since we have hit these errors a couple times before:
Linux
|
Created by
brew bump
Created with
brew bump-formula-pr
.