Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubberband 3.1.0 #112467

Closed
wants to merge 2 commits into from
Closed

rubberband 3.1.0 #112467

wants to merge 2 commits into from

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Oct 6, 2022
@cho-m
Copy link
Member

cho-m commented Oct 6, 2022

Previous attempt -- #112048.

MacOS's /usr/bin/javac doesn't play well with Meson build script as it ends up thinking Java is installed.

I don't think we want to make OpenJDK a dependency as it should be an optional feature.

@carlocab
Copy link
Member

carlocab commented Oct 6, 2022

We should patch out the Java check and report the bug to Meson, I think.

@cho-m
Copy link
Member

cho-m commented Oct 7, 2022

Someone opened a Meson issue relating to this: mesonbuild/meson#10900

May also want to see if Rubberband is willing to add Meson option to manually disable JNI feature so that we can avoid feature getting enabled if build system has OpenJDK installed.

@cho-m
Copy link
Member

cho-m commented Oct 7, 2022

Alternatively, if there is no linkage, we could make openjdk a build-time dependency and allow users to install openjdk if they want to use JNI. I don't think it links on macOS, but not sure about Linux

@carlocab
Copy link
Member

carlocab commented Oct 7, 2022

Could make the build dependency macOS-only.

@cho-m
Copy link
Member

cho-m commented Oct 7, 2022

I also don't see linkage for JNI on Linux, so could make build-only. We originally packaged Linux with openjdk dependency but I dropped it in #105339 since it was broken with 3.0.0

$ ldd /home/linuxbrew/.linuxbrew/Cellar/rubberband/3.1.0/lib/librubberband-jni.so
	libfftw3.so.3 => /home/linuxbrew/.linuxbrew/opt/fftw/lib/libfftw3.so.3 (0x000000400189c000)
	libsamplerate.so.0 => /home/linuxbrew/.linuxbrew/opt/libsamplerate/lib/libsamplerate.so.0 (0x0000004001c00000)
	libstdc++.so.6 => /home/linuxbrew/.linuxbrew/opt/gcc/lib/gcc/current/libstdc++.so.6 (0x00000040020ef000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x0000004002368000)
	libgcc_s.so.1 => /home/linuxbrew/.linuxbrew/opt/gcc/lib/gcc/current/libgcc_s.so.1 (0x000000400244f000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x0000004002472000)
	/lib64/ld-linux-x86-64.so.2 (0x0000004000000000)

@BrewTestBot BrewTestBot added the java Java use is a significant feature of the PR or issue label Oct 7, 2022
@cho-m cho-m added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Oct 8, 2022
@cho-m
Copy link
Member

cho-m commented Oct 8, 2022

Unrelated to this PR but caffe needs to be rebuild. Looks like it was a leftover from boost:

Full linkage --test caffe output
  Missing libraries:
    unexpected (libboost_thread-mt.so.1.79.0)

@carlocab carlocab added the long build Set a long timeout for formula testing label Oct 8, 2022
@cho-m cho-m removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 8, 2022
@cho-m
Copy link
Member

cho-m commented Oct 8, 2022

None of failures seem related.

Catalina failure on download failure. Do we not have any retries for CI to avoid sporadic failures since we have hit these errors a couple times before:

  curl: (35) LibreSSL SSL_connect: SSL_ERROR_SYSCALL in connection to pkg-containers.githubusercontent.com:443 
  Error: audacious: Failed to download resource "libunistring"

Linux

@cho-m cho-m added the ready to merge PR can be merged once CI is green label Oct 8, 2022
@BrewTestBot
Copy link
Member Author

:shipit: @carlocab has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Nov 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
@p-linnane p-linnane deleted the bump-rubberband-3.1.0 branch February 24, 2024 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. java Java use is a significant feature of the PR or issue long build Set a long timeout for formula testing outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants