Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-tools 2022.12 (new formula) #133285

Closed
wants to merge 5 commits into from
Closed

git-tools 2022.12 (new formula) #133285

wants to merge 5 commits into from

Conversation

cirrusj
Copy link
Contributor

@cirrusj cirrusj commented Jun 9, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This is git-tools, which incudes the following:

  • git-restore-mtime: Restore original modification time of files based on the date of the most recent commit that modified them
  • git-branches-rename: Batch renames branches with a matching prefix to another prefix
  • git-clone-subset: Clones a subset of a git repository
  • git-find-uncommitted-repos: Recursively list repos with uncommitted changes
  • git-rebase-theirs: Resolve rebase conflicts and failed cherry-picks by favoring 'theirs' version
  • git-strip-merge: A git-merge wrapper that delete files on a "foreign" branch before merging

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Jun 9, 2023
@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. python Python use is a significant feature of the PR or issue labels Jun 9, 2023
@cirrusj
Copy link
Contributor Author

cirrusj commented Jun 9, 2023

Not sure why the test is failing in macOS 12, all tests pass fine in macOS 13. git-branches-rename is a shell script that uses awk, so it could be related with 12 having an older version (not sure - don't have access to a system with 12).
If anyone can help, it would be appreciated.

carlocab
carlocab reviewed Jun 10, 2023
View reviewed changes
Formula/git-tools.rb Outdated Show resolved Hide resolved
Formula/git-tools.rb Outdated Show resolved Hide resolved
Formula/git-tools.rb Outdated Show resolved Hide resolved
@cirrusj
Copy link
Contributor Author

cirrusj commented Jun 10, 2023

Thanks for the help @carlocab

carlocab
carlocab previously approved these changes Jun 11, 2023
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlocab carlocab added the ready to merge PR can be merged once CI is green label Jun 11, 2023
@github-actions
Copy link
Contributor

🤖 An automated task has requested creation of a replacement PR.

@github-actions github-actions bot dismissed carlocab’s stale review June 11, 2023 09:00

Replacement PR dispatched

@BrewTestBot BrewTestBot mentioned this pull request Jun 11, 2023
Merged
BrewTestBot pushed a commit that referenced this pull request Jun 11, 2023
@cirrusj @BrewTestBot
git-tools 2022.12 (new formula)
9f99861 
* git-tools 2022.12 (new formula)
* git-tools: remove macos python
* git-tools: Fix dependencies
* git-tools: Fix failing test
* git-tools: replace Dir with buildpath.glob

Closes #133285.

Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request superseded PR was replaced by another PR labels Jun 11, 2023
@github-actions
Copy link
Contributor

✅ Replacement PR created at #133361.

BrewTestBot added a commit that referenced this pull request Jun 11, 2023
@BrewTestBot
Merge pull request #133361 from Homebrew/PR/133285
1e37006 
Replacement for #133285
@chrisfinazzo
Copy link
Contributor

Updated instructions for Homebrew can be found here.

@MestreLion
Copy link

Nice!

Just one note: the license is GPL-3.0-or-later, not GPL-3.0-only. Not that it matters in practice...

If you need any assistance just ping me!

@cirrusj cirrusj deleted the git-tools branch June 15, 2023 09:44
@cirrusj
Copy link
Contributor Author

cirrusj commented Jun 15, 2023

Sorry for that, I've created #133811 fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab left review comments

Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request autosquash Automatically squash pull request commits according to Homebrew style. new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green superseded PR was replaced by another PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cirrusj @chrisfinazzo @MestreLion @carlocab