Enable determinstic archives by default in GNU ar #14860
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 22, 2017 19:21
Timestamps and user ids are not really needed in ar archives, and get in the way of reproducible builds, so let's make -D the default. freebsd did it a year ago: https://svnweb.freebsd.org/ports?view=revision&revision=416639 debian did it way back in 2.25-6: https://wiki.debian.org/ReproducibleBuilds/TimestampsInStaticLibraries Fixes Homebrew#14859 See also https://reproducible-builds.org/
… since this formula was created
dankegel
pushed a commit
to dankegel/fpm
that referenced
this pull request
Jun 23, 2017
… builds Needed e.g. on mac, where system ar is old, but gnu ar is available as 'gar' via 'brew install binutils'. Eventually this commit can be reverted, once all ar's in existence default to no timestamps. (cf. Homebrew/homebrew-core#14860 but don't wait for that to land)
|
Sounds good to me. Merged as a05f19a, thanks for contributing to Homebrew! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Timestamps and user ids are not really needed in
ar archives, and get in the way of reproducible builds,
so let's make -D the default.
freebsd did it a year ago: https://svnweb.freebsd.org/ports?view=revision&revision=416639
debian did it way back in 2.25-6: https://wiki.debian.org/ReproducibleBuilds/TimestampsInStaticLibraries
Fixes #14859
See also https://reproducible-builds.org/
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?