New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lftp 4.7.2 #1509

Closed
wants to merge 1 commit into
base: master
from

Conversation

9 participants
@nijikon
Contributor

nijikon commented May 28, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?

@DomT4

This comment has been minimized.

Show comment
Hide comment
@DomT4

DomT4 May 28, 2016

Contributor

Failing to build on all platforms:

/bin/sh ../libtool --silent  --tag=CXX   --mode=compile clang++ -DHAVE_CONFIG_H -I. -I../lib  -I../lib -I../trio -I/usr/include -I/usr/local/opt/openssl/include    -O2 -Wall -Wwrite-strings -Woverloaded-virtual -fno-exceptions -fno-rtti -fno-implement-inlines -c -o liblftp_network_la-RateLimit.lo `test -f 'RateLimit.cc' || echo './'`RateLimit.cc
lftp_ssl.cc:827:14: error: use of undeclared identifier 'SSL_OP_NO_TLSv1_1'
         {"-TLS1.1",SSL_OP_NO_TLSv1_1},
                    ^
lftp_ssl.cc:828:14: error: use of undeclared identifier 'SSL_OP_NO_TLSv1_2'
         {"-TLS1.2",SSL_OP_NO_TLSv1_2},
                    ^

I don't even get that far locally, for some reason:

clang -DHAVE_CONFIG_H -I. -I../lib  -I../lib -I../trio -I/usr/include/readline   -g -O2 -Wall -c -o lftp-lftp_rl.o `test -f 'lftp_rl.c' || echo './'`lftp_rl.c
In file included from lftp_rl.c:23:
In file included from ./history.h:23:
In file included from ./keyvalue.h:23:
In file included from ./xstring.h:97:
./xmalloc.h:31:38: error: C does not support default arguments
char *xstrdup(const char *s,int spare=0);
                                     ^~
./xmalloc.h:32:21: error: expected ')'
char *xstrset(char *&mem,const char *s);
                    ^
./xmalloc.h:32:14: note: to match this '('
char *xstrset(char *&mem,const char *s);
             ^
./xmalloc.h:33:21: error: expected ')'
char *xstrset(char *&mem,const char *s,size_t n);
                    ^
./xmalloc.h:33:14: note: to match this '('
char *xstrset(char *&mem,const char *s,size_t n);
             ^
In file included from lftp_rl.c:23:
In file included from ./history.h:23:
In file included from ./keyvalue.h:23:
./xstring.h:104:1: error: unknown type name 'class'
class xstring0 // base class
^
./xstring.h:104:15: error: expected ';' after top level declarator
class xstring0 // base class
              ^
              ;
./xstring.h:123:1: error: unknown type name 'class'
class xstring_c : public xstring0
^
./xstring.h:123:17: error: expected ';' after top level declarator
class xstring_c : public xstring0
                ^
                ;
./xstring.h:123:19: error: unknown type name 'public'
class xstring_c : public xstring0
                  ^
./xstring.h:123:34: error: expected ';' after top level declarator
class xstring_c : public xstring0
                                 ^
                                 ;
./xstring.h:157:1: error: unknown type name 'class'
class xstring_ca : public xstring_c
^
./xstring.h:157:18: error: expected ';' after top level declarator
class xstring_ca : public xstring_c
                 ^
                 ;
./xstring.h:157:20: error: unknown type name 'public'
class xstring_ca : public xstring_c
                   ^
./xstring.h:157:36: error: expected ';' after top level declarator
class xstring_ca : public xstring_c
                                   ^
                                   ;
./xstring.h:165:1: error: unknown type name 'class'
class xstring_clonable;
^
./xstring.h:167:1: error: unknown type name 'class'
class xstring : public xstring0
^
./xstring.h:167:15: error: expected ';' after top level declarator
class xstring : public xstring0
              ^
              ;
./xstring.h:167:17: error: unknown type name 'public'
class xstring : public xstring0
                ^
./xstring.h:167:32: error: expected ';' after top level declarator
class xstring : public xstring0
                               ^
                               ;
./xstring.h:286:1: error: unknown type name 'class'
class xstring_clonable : public xstring {};
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make[2]: *** [lftp-lftp_rl.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [install-recursive] Error 1
make: *** [install] Error 2
Contributor

DomT4 commented May 28, 2016

Failing to build on all platforms:

/bin/sh ../libtool --silent  --tag=CXX   --mode=compile clang++ -DHAVE_CONFIG_H -I. -I../lib  -I../lib -I../trio -I/usr/include -I/usr/local/opt/openssl/include    -O2 -Wall -Wwrite-strings -Woverloaded-virtual -fno-exceptions -fno-rtti -fno-implement-inlines -c -o liblftp_network_la-RateLimit.lo `test -f 'RateLimit.cc' || echo './'`RateLimit.cc
lftp_ssl.cc:827:14: error: use of undeclared identifier 'SSL_OP_NO_TLSv1_1'
         {"-TLS1.1",SSL_OP_NO_TLSv1_1},
                    ^
lftp_ssl.cc:828:14: error: use of undeclared identifier 'SSL_OP_NO_TLSv1_2'
         {"-TLS1.2",SSL_OP_NO_TLSv1_2},
                    ^

I don't even get that far locally, for some reason:

clang -DHAVE_CONFIG_H -I. -I../lib  -I../lib -I../trio -I/usr/include/readline   -g -O2 -Wall -c -o lftp-lftp_rl.o `test -f 'lftp_rl.c' || echo './'`lftp_rl.c
In file included from lftp_rl.c:23:
In file included from ./history.h:23:
In file included from ./keyvalue.h:23:
In file included from ./xstring.h:97:
./xmalloc.h:31:38: error: C does not support default arguments
char *xstrdup(const char *s,int spare=0);
                                     ^~
./xmalloc.h:32:21: error: expected ')'
char *xstrset(char *&mem,const char *s);
                    ^
./xmalloc.h:32:14: note: to match this '('
char *xstrset(char *&mem,const char *s);
             ^
./xmalloc.h:33:21: error: expected ')'
char *xstrset(char *&mem,const char *s,size_t n);
                    ^
./xmalloc.h:33:14: note: to match this '('
char *xstrset(char *&mem,const char *s,size_t n);
             ^
In file included from lftp_rl.c:23:
In file included from ./history.h:23:
In file included from ./keyvalue.h:23:
./xstring.h:104:1: error: unknown type name 'class'
class xstring0 // base class
^
./xstring.h:104:15: error: expected ';' after top level declarator
class xstring0 // base class
              ^
              ;
./xstring.h:123:1: error: unknown type name 'class'
class xstring_c : public xstring0
^
./xstring.h:123:17: error: expected ';' after top level declarator
class xstring_c : public xstring0
                ^
                ;
./xstring.h:123:19: error: unknown type name 'public'
class xstring_c : public xstring0
                  ^
./xstring.h:123:34: error: expected ';' after top level declarator
class xstring_c : public xstring0
                                 ^
                                 ;
./xstring.h:157:1: error: unknown type name 'class'
class xstring_ca : public xstring_c
^
./xstring.h:157:18: error: expected ';' after top level declarator
class xstring_ca : public xstring_c
                 ^
                 ;
./xstring.h:157:20: error: unknown type name 'public'
class xstring_ca : public xstring_c
                   ^
./xstring.h:157:36: error: expected ';' after top level declarator
class xstring_ca : public xstring_c
                                   ^
                                   ;
./xstring.h:165:1: error: unknown type name 'class'
class xstring_clonable;
^
./xstring.h:167:1: error: unknown type name 'class'
class xstring : public xstring0
^
./xstring.h:167:15: error: expected ';' after top level declarator
class xstring : public xstring0
              ^
              ;
./xstring.h:167:17: error: unknown type name 'public'
class xstring : public xstring0
                ^
./xstring.h:167:32: error: expected ';' after top level declarator
class xstring : public xstring0
                               ^
                               ;
./xstring.h:286:1: error: unknown type name 'class'
class xstring_clonable : public xstring {};
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make[2]: *** [lftp-lftp_rl.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [install-recursive] Error 1
make: *** [install] Error 2
@nijikon

This comment has been minimized.

Show comment
Hide comment
@nijikon

nijikon Jul 4, 2016

Contributor

@DomT4 please review

Contributor

nijikon commented Jul 4, 2016

@DomT4 please review

depends_on "openssl"
depends_on "openssl" if MacOS.version < :yosemite
patch do

This comment has been minimized.

@DomT4

DomT4 Jul 4, 2016

Contributor

Same question re has this been submitted upstream/etc?

@DomT4

DomT4 Jul 4, 2016

Contributor

Same question re has this been submitted upstream/etc?

This comment has been minimized.

@nijikon

nijikon Jul 10, 2016

Contributor

It's reported in the linked PR and all patches are from there.

@nijikon

nijikon Jul 10, 2016

Contributor

It's reported in the linked PR and all patches are from there.

This comment has been minimized.

@DomT4

DomT4 Jul 10, 2016

Contributor

Please note that link in the formula with the standard #. We can't realistically expect future contributors to comb through old PRs for answers.

@DomT4

DomT4 Jul 10, 2016

Contributor

Please note that link in the formula with the standard #. We can't realistically expect future contributors to comb through old PRs for answers.

depends_on "pkg-config" => :build
depends_on "readline"
depends_on "openssl"
depends_on "openssl" if MacOS.version < :yosemite

This comment has been minimized.

@DomT4

DomT4 Jul 4, 2016

Contributor

Is this using CommonCrypto on newer systems now?

@DomT4

DomT4 Jul 4, 2016

Contributor

Is this using CommonCrypto on newer systems now?

This comment has been minimized.

@nijikon

nijikon Jul 10, 2016

Contributor

I don't know

@nijikon

nijikon Jul 10, 2016

Contributor

I don't know

This comment has been minimized.

@DomT4

DomT4 Jul 10, 2016

Contributor

Looking at the upstream repo it seems to use either OpenSSL or GnuTLS, so not sure we should be limiting this to :yosemite. Can you check the linkage of this PR with depends_on "openssl" to see if it's actually linking?

@DomT4

DomT4 Jul 10, 2016

Contributor

Looking at the upstream repo it seems to use either OpenSSL or GnuTLS, so not sure we should be limiting this to :yosemite. Can you check the linkage of this PR with depends_on "openssl" to see if it's actually linking?

This comment has been minimized.

@apjanke

apjanke Aug 22, 2016

Contributor

I ran it on El Cap and it's still trying to use openssl, which is now an error when it tries to use the system openssl. That means this dependency should not be limited to < :yosemite.


In file included from FileAccess.cc:1021:
In file included from ./ftpclass.h:29:
./lftp_ssl.h:27:12: fatal error: 'openssl/ssl.h' file not found
#  include <openssl/ssl.h>
           ^
/bin/sh ../libtool --silent  --tag=CXX   --mode=compile clang++ -DHAVE_CONFIG_H -I. -I../lib  -I../lib -I../trio   -O2 -Wall -Wwrite-strings -Woverloaded-virtual -fno-exceptions -fno-rtti -fno-implement-inlines -c -o StringSet.lo StringSet.cc
1 error generated.
make[2]: *** [FileAccess.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [install-recursive] Error 1
make: *** [install] Error 2
@apjanke

apjanke Aug 22, 2016

Contributor

I ran it on El Cap and it's still trying to use openssl, which is now an error when it tries to use the system openssl. That means this dependency should not be limited to < :yosemite.


In file included from FileAccess.cc:1021:
In file included from ./ftpclass.h:29:
./lftp_ssl.h:27:12: fatal error: 'openssl/ssl.h' file not found
#  include <openssl/ssl.h>
           ^
/bin/sh ../libtool --silent  --tag=CXX   --mode=compile clang++ -DHAVE_CONFIG_H -I. -I../lib  -I../lib -I../trio   -O2 -Wall -Wwrite-strings -Woverloaded-virtual -fno-exceptions -fno-rtti -fno-implement-inlines -c -o StringSet.lo StringSet.cc
1 error generated.
make[2]: *** [FileAccess.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [install-recursive] Error 1
make: *** [install] Error 2

@apjanke apjanke referenced this pull request Aug 22, 2016

Closed

lftp 4.7.2 #4140

@apjanke apjanke self-assigned this Aug 22, 2016

@apjanke apjanke added the in progress label Aug 22, 2016

@apjanke

This comment has been minimized.

Show comment
Hide comment
@apjanke

apjanke Aug 22, 2016

Contributor

Build is failing on Yosemite only when depends_on 'openssl' is included (up in #4140). Failed build: https://bot.brew.sh/job/Homebrew%20Core%20Pull%20Requests/6654/.

The author says:

I don't have OS X anywhere nearby. Sorry.

and there's no indication that the patches for OS X are going to make it in to upstream. Maybe this is a candidate for boneyarding until someone makes an OS X port of lftp, or at least skipping this version?

Contributor

apjanke commented Aug 22, 2016

Build is failing on Yosemite only when depends_on 'openssl' is included (up in #4140). Failed build: https://bot.brew.sh/job/Homebrew%20Core%20Pull%20Requests/6654/.

The author says:

I don't have OS X anywhere nearby. Sorry.

and there's no indication that the patches for OS X are going to make it in to upstream. Maybe this is a candidate for boneyarding until someone makes an OS X port of lftp, or at least skipping this version?

@dunn

This comment has been minimized.

Show comment
Hide comment
@dunn

dunn Aug 31, 2016

Contributor

Yeah, I'd say skip this version and unless the next version works, 💀

Contributor

dunn commented Aug 31, 2016

Yeah, I'd say skip this version and unless the next version works, 💀

@DomT4

This comment has been minimized.

Show comment
Hide comment
@DomT4

DomT4 Sep 3, 2016

Contributor

FWIW, 4.6.6 builds so it might be worth updating to that at least, but I hadn't managed to get any of the new 4.7.x branch building to date.

Contributor

DomT4 commented Sep 3, 2016

FWIW, 4.6.6 builds so it might be worth updating to that at least, but I hadn't managed to get any of the new 4.7.x branch building to date.

@MoOx

This comment has been minimized.

Show comment
Hide comment
@MoOx

MoOx Oct 11, 2016

FYI 4.6.6 seems to be unavailable or something

❯❯ brew install homebrew/boneyard/lftp

==> Installing lftp from homebrew/boneyard
==> Downloading https://lftp.yar.ru/ftp/lftp-4.6.6.tar.xz

curl: (7) Failed to connect to lftp.yar.ru port 443: Connection refused
Error: Failed to download resource "lftp"
Download failed: https://lftp.yar.ru/ftp/lftp-4.6.6.tar.xz

I tried with a VPN, same issue, and I can't find the link to 4.6.6 on the website. So this sucks :(

MoOx commented Oct 11, 2016

FYI 4.6.6 seems to be unavailable or something

❯❯ brew install homebrew/boneyard/lftp

==> Installing lftp from homebrew/boneyard
==> Downloading https://lftp.yar.ru/ftp/lftp-4.6.6.tar.xz

curl: (7) Failed to connect to lftp.yar.ru port 443: Connection refused
Error: Failed to download resource "lftp"
Download failed: https://lftp.yar.ru/ftp/lftp-4.6.6.tar.xz

I tried with a VPN, same issue, and I can't find the link to 4.6.6 on the website. So this sucks :(

@MoOx

This comment has been minimized.

Show comment
Hide comment
@MoOx

MoOx Oct 11, 2016

Workaround is to get version from here ftp://ftp.st.ryukoku.ac.jp/pub/network/ftp/lftp/ and move it to brew cache in ~/Library/Caches/Homebrew/

MoOx commented Oct 11, 2016

Workaround is to get version from here ftp://ftp.st.ryukoku.ac.jp/pub/network/ftp/lftp/ and move it to brew cache in ~/Library/Caches/Homebrew/

@tuupola

This comment has been minimized.

Show comment
Hide comment
@tuupola

tuupola Oct 14, 2016

Currently downloads ok.

$ wget https://lftp.yar.ru/ftp/lftp-4.6.6.tar.xz
--2016-10-14 16:42:47--  https://lftp.yar.ru/ftp/lftp-4.6.6.tar.xz
Resolving lftp.yar.ru... 213.187.99.145, 2a03:ca00:2:908:a00:27ff:fe6d:a9cc
Connecting to lftp.yar.ru|213.187.99.145|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 1518544 (1.4M) [application/x-xz]
Saving to: 'lftp-4.6.6.tar.xz'

lftp-4.6.6.tar.xz   100%[=====================>]   1.45M  2.27MB/s   in 0.6s   

2016-10-14 16:42:49 (2.27 MB/s) - 'lftp-4.6.6.tar.xz' saved [1518544/1518544]

tuupola commented Oct 14, 2016

Currently downloads ok.

$ wget https://lftp.yar.ru/ftp/lftp-4.6.6.tar.xz
--2016-10-14 16:42:47--  https://lftp.yar.ru/ftp/lftp-4.6.6.tar.xz
Resolving lftp.yar.ru... 213.187.99.145, 2a03:ca00:2:908:a00:27ff:fe6d:a9cc
Connecting to lftp.yar.ru|213.187.99.145|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 1518544 (1.4M) [application/x-xz]
Saving to: 'lftp-4.6.6.tar.xz'

lftp-4.6.6.tar.xz   100%[=====================>]   1.45M  2.27MB/s   in 0.6s   

2016-10-14 16:42:49 (2.27 MB/s) - 'lftp-4.6.6.tar.xz' saved [1518544/1518544]
@zgist

This comment has been minimized.

Show comment
Hide comment
@dunn

This comment has been minimized.

Show comment
Hide comment
@dunn

dunn Dec 15, 2016

Contributor

See #7371

Contributor

dunn commented Dec 15, 2016

See #7371

@Homebrew Homebrew locked and limited conversation to collaborators Dec 15, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.