glib 2.52.3- fix pkg-config for linking non-framework libraries #15693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caused problems downstream when linking unix libraries which are not frameworks
ilovezfs
reviewed
Jul 17, 2017
| @@ -89,6 +89,9 @@ def install | |||
| "Libs: -L${libdir} -lglib-2.0 -L#{gettext}/lib -lintl" | |||
| s.gsub! "Cflags: -I${includedir}/glib-2.0 -I${libdir}/glib-2.0/include", | |||
| "Cflags: -I${includedir}/glib-2.0 -I${libdir}/glib-2.0/include -I#{gettext}/include" | |||
| # correct linking of framework - caused broken links downstream | |||
There was a problem hiding this comment.
Please report this upstream and link to the report here.
There was a problem hiding this comment.
What do you mean with "upstream"?
There was a problem hiding this comment.
homepage "https://developer.gnome.org/glib/"
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
@Stale[bot] This still should be reported upstream. |
|
@StephanSiemen what's the status here? |
|
Closing, because:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
caused problems downstream when linking unix libraries which are not frameworks
See message: https://discourse.brew.sh/t/linking-libraries-problem-caused-by-glib-pkg-config-file/927
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?