Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mercurial 4.3 #16634

Closed
wants to merge 1 commit into from
Closed

mercurial 4.3 #16634

wants to merge 1 commit into from

Conversation

@alex
Copy link
Contributor

@alex alex commented Aug 10, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@alex
Copy link
Contributor Author

@alex alex commented Aug 10, 2017

Test failures don't look like they were caused by this PR, they look like they're cause by a conflict between git-cinnabar and git-remote-hg.

@alex
Copy link
Contributor Author

@alex alex commented Aug 10, 2017

Fixes CVE-2017-1000115, CVE-2017-1000116

@elyscape
Copy link
Contributor

@elyscape elyscape commented Aug 10, 2017

The test error should be resolved by adding a line to the git-remote-hg formula:

conflicts_with "git-cinnabar", :because => "both install `git-remote-hg` binaries"

A similar line is already present in the git-cinnabar formula.

What's going on is that these formulae conflict, but only git-cinnabar declares this. Since git-cinnabar is lexically higher than git-remote-hg, the test bot installs it first when performing tests. When it comes time to install git-remote-hg, since that doesn't declare any conflicts, the test bot doesn't bother unlinking git-cinnabar, and this error is the result.

@ilovezfs ilovezfs closed this in 0b9963c Aug 10, 2017
@ilovezfs
Copy link
Contributor

@ilovezfs ilovezfs commented Aug 10, 2017

Thanks @alex! 🔒

@ilovezfs
Copy link
Contributor

@ilovezfs ilovezfs commented Aug 10, 2017

@elyscape feel like opening a pull request?

@alex alex deleted the alex:patch-1 branch Aug 10, 2017
@elyscape elyscape mentioned this pull request Aug 10, 2017
4 of 4 tasks complete
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants