New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdfcli 17.2.0 #17795

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@tjtyrrell
Copy link

tjtyrrell commented Sep 7, 2017

SDFCLI is an application distributed by Oracle-NetSuite. Unfortunately
the installation instructions are locked behind an account access help
center. The product itself is open-source, but worthless without a
NetSuite account. This will let people easily install the tool without
going through the fairly complicated installation instructions.

  • [ x ] Have you followed the guidelines for contributing?
  • [ x ] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [ x ] Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [ x ] Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

tjtyrrell added some commits Sep 7, 2017

NetSuite SDFCLI 17.2.0 - New Formula
SDFCLI is an application distributed by Oracle-NetSuite. Unfortunately
the installation instructions are locked behind an account access help
center. The product itself is open-source, but worthless without a
NetSuite account. This will let people easily install the tool without
going through the fairly complicated installation instructions.
@JCount

This comment has been minimized.

Copy link
Contributor

JCount commented Sep 8, 2017

The license of the software in this formula states:

  1. You shall not distribute the SuiteCloud IDE. You agree that the use and
    distribution of Your Application shall be in accordance with the NetSuite
    SuiteCloud Terms of Service. You may not prepare any derivative works of the
    SuiteCloud IDE. You may not disassemble, decompile or reverse engineer the
    SuiteCloud IDE non-open source components in order to obtain the source code,
    which is a trade secret of NetSuite and/or its suppliers. You may not sell,
    rent, loan, lease, sublease, assign, or otherwise transfer the SuiteCloud IDE.
    You agree to reproduce any copyright and other proprietary right notices on any
    copies of the SuiteCloud IDE.

Unfortunately, this strongly indicates that this software is not something we should distribute through Homebrew in a formula.

@JCount JCount closed this Sep 8, 2017

@tjtyrrell

This comment has been minimized.

Copy link
Author

tjtyrrell commented Sep 8, 2017

So unfortunately NetSuite did not make any adjustments to their original license, and that was the one I used for the CLI. Please see the line 154 of the license that describes WHAT the SuiteCloud IDE is. It is a plugin for Eclipse, not this CLI app.

THIRD PARTY CODE

The SuiteCloud IDE may contain the version of the components listed below or
later versions.

The SuiteCloud IDE is a plugin built on top of the Eclipse IDE and requires
either "Eclipse IDE for JavaScript Web Developers (Version 3.7)" or "Eclipse IDE
for Java EE Developers (Eclipse 4.3)" to run. The SuiteCloud IDE may contain
code from the Eclipse IDE, which is licensed pursuant to the Eclipse Public
License available at http://www.eclipse.org/legal/epl-v10.html. The source code
for both versions of eclipse IDE is available via download at
http://www.eclipse.org.

If you are looking at a different license, this part of the license starts at "Third Party Code".

Given that these are unrelated software, should I remove that part of the license? As of present this is the only license I could find for this particular piece of software.

Thank you

@JCount

This comment has been minimized.

Copy link
Contributor

JCount commented Sep 9, 2017

@tjtyrrell That statement is from the license that applies the the software this formula would install. The "Third Party Code" section of the license you are pointing to merely applies to the software's use of third-party code.

Let me be clear, there are also numerous other issues. This was merely the easiest and clearest one to point out.

@tjtyrrell

This comment has been minimized.

Copy link
Author

tjtyrrell commented Sep 9, 2017

The statement is in the Third Party section, yes. But it describes what the "SuiteCloud IDE" is (specifically, "The SuiteCloud IDE is a plugin built on top of the Eclipse IDE"... This is a CLI tool, not an Eclipse Plugin, nor does it have anything associated with Eclipse). Regardless, I am doing this on the blessing from the people who made the product (the NetSuite platform team). If this was just an issue with the license, I can have them give me a formal acknowledgement allowing me to do this through brew or I can just remove the one for the SuiteCloud IDE and ask them to give me an open source license to use for the NetSuite SDFCLI.

Can you please help me resolve the "numerous" issues you speak of? Can you please advise me on what I am doing wrong so that I can make the appropriate corrections. This is my first brew, and my first Ruby script (which isn't much of a Ruby script anyway). I am just trying to help the community and feel like I followed the rules of the brew community, but if I haven't, I could use help.

Thank you in advance,

TJ

@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Sep 9, 2017

Where's the source code for com.netsuite.ide.core_2017.2.0.jar hosted?

@tjtyrrell

This comment has been minimized.

Copy link
Author

tjtyrrell commented Sep 9, 2017

So apparently the source code is not locked behind a password. You can download the .jar file here:
https://system.netsuite.com/download/ide/update_17_2/plugins/com.netsuite.ide.core_2017.2.0.jar
It was inactive for about 3 days, but they seem to have resolved the issue (I haven't confirmed if the sha256 has changed between the one I downloaded a week ago and this one now that they've made it available again. My download came from 9/2/17). If I need to remove the .jar file from my git hosted tar.gz file, I can do that. Unfortunately there are several files that don't come with the .jar file (like the pom.xml). Any suggestions on how I can make those types of adjustments would be extremely helpful and I appreciate any and all support.

If I need to give someone at homebrew temporary access to my developer NetSuite account so you can explore the help and release documents, I can do that in order to help pass this through.

Also note, this software is absolutely worthless to anyone who doesn't have a NetSuite account. But the installation instructions on the NetSuite help center are much more confusing than they have to be (several dependencies like java and maven as well as setting up the dependency files like the pom.xml), so I wanted to create a brew installer to simplify the process.

Thank you for working with me.

@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Sep 9, 2017

Also note, this software is absolutely worthless to anyone who doesn't have a NetSuite account.

I think this would be a good fit for a 3rd party tap. Users can then do

brew install tjtyrrell/sdfcli/sdfcli

or

brew tap tjtyrrell/sdfcli
brew install sdfcli

You can follow the instructions here: https://github.com/Homebrew/brew/blob/master/docs/How-to-Create-and-Maintain-a-Tap.md#how-to-create-and-maintain-a-tap

@tjtyrrell

This comment has been minimized.

Copy link
Author

tjtyrrell commented Sep 9, 2017

Ok, if that is a better solution that would work for me. I haven't used brew that often except for some of my core software installs, so I was unaware of the tap functionality.

Thank you for your help,

TJ

@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Sep 9, 2017

@tjtyrrell you're welcome. Let me know if you get stuck setting up the tap :)

@tjtyrrell

This comment has been minimized.

Copy link
Author

tjtyrrell commented Sep 9, 2017

Seems to have worked like a charm, I set it up on my company git account and tested it on my local mac using:

brew install limebox/sdfcli/sdfcli

One quick question, is there a common name I could use for the formula to install without having to replicate the sdfcli part?

Meaning, it would be nice if they could type:
brew install limebox/sdfcli

and if I had a formula in a repo like so: limebox/homebrew-sdfcli/formula.rb that brew would install that one?

If not, oh well. Couldn't hurt to ask and I don't see it in the link you sent.

Have a fantastic weekend,

TJ

@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Sep 9, 2017

is there a common name I could use for the formula to install without having to replicate the sdfcli part

No, but the tap can have any name and contain any number of formulae. So maybe limebox/netsuite would make sense for the tap name, and then users can do brew install limebox/netsuite/sdfcli.

@tjtyrrell

This comment has been minimized.

Copy link
Author

tjtyrrell commented Sep 9, 2017

Makes sense! Again, thank you so much for your help!

Have a wonderful weekend!

@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Sep 9, 2017

You're welcome! You, too!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.