Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ldc 1.4.0 #17966

Closed
wants to merge 2 commits into from
Closed

ldc 1.4.0 #17966

wants to merge 2 commits into from

Conversation

John-Colvin
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@ilovezfs
Copy link
Contributor

@John-Colvin it seems the test fails.

@ilovezfs ilovezfs added test failure CI fails while running the test-do block and removed test failure CI fails while running the test-do block labels Sep 12, 2017
@ilovezfs
Copy link
Contributor

The test is still failing with the updated bootstrapper.

@ilovezfs ilovezfs added the test failure CI fails while running the test-do block label Sep 13, 2017
@sambrightman
Copy link
Contributor

sambrightman commented Sep 17, 2017 •
edited
Loading

These two releases add support for LLVM 5.0, so I believe the dependency on llvm@4 can be changed to the default llvm (there are a couple of other references to llvm@4 as well). I have sporadic build failures though, in addition to the failing test.

@ilovezfs
Copy link
Contributor

@BrewTestBot test this please

2 similar comments
@ilovezfs
Copy link
Contributor

@BrewTestBot test this please

@ilovezfs
Copy link
Contributor

@BrewTestBot test this please

@John-Colvin
Copy link
Contributor Author

@BrewTestBot test this please

@John-Colvin
Copy link
Contributor Author

The tests all passed except for one network problem on one run, which was wiki.dlang.org going down temporarily.

@John-Colvin
Copy link
Contributor Author

@BrewTestBot test this please

ilovezfs
ilovezfs reviewed Sep 28, 2017
View reviewed changes
Formula/ldc.rb
-DINCLUDE_INSTALL_DIR=#{include}/dlang/ldc
-DD_COMPILER=#{buildpath}/ldc-lts/build/bin/ldmd2
-DLDC_WITH_LLD=OFF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do these two new args do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see added comments below

@John-Colvin
Copy link
Contributor Author

this is good to go I think

@John-Colvin
Copy link
Contributor Author

woops, had the comments the wrong way around, good now

@John-Colvin
Copy link
Contributor Author

@BrewTestBot test this please

@John-Colvin
Copy link
Contributor Author

Ping?

@ilovezfs
Copy link
Contributor

ilovezfs commented Oct 2, 2017

Shipped! Thanks @John-Colvin and sorry for the wait

@ilovezfs ilovezfs removed the test failure CI fails while running the test-do block label Oct 2, 2017
@ilovezfs ilovezfs closed this in 947b1cc Oct 2, 2017
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilovezfs ilovezfs ilovezfs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@John-Colvin @ilovezfs @sambrightman