New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible 2.4.0.0 & remove obsolete workaround #18424

Closed
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@rdewaele

rdewaele commented Sep 22, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

The other version bump pull request (#18252) seems to fail checks and diff shows it has not removed the failing workaround.

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Sep 22, 2017

Contributor

Please do not open duplicates.

Contributor

ilovezfs commented Sep 22, 2017

Please do not open duplicates.

@ilovezfs ilovezfs closed this Sep 22, 2017

@rdewaele

This comment has been minimized.

Show comment
Hide comment
@rdewaele

rdewaele Sep 22, 2017

How is this a duplicate if the other build is failing? Not sure how I can amend someone else's pull request.

rdewaele commented Sep 22, 2017

How is this a duplicate if the other build is failing? Not sure how I can amend someone else's pull request.

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Sep 22, 2017

Contributor

Also, please do not ask rhetorical questions.

Contributor

ilovezfs commented Sep 22, 2017

Also, please do not ask rhetorical questions.

@rdewaele

This comment has been minimized.

Show comment
Hide comment
@rdewaele

rdewaele Sep 22, 2017

I am sorry, this is really not intended to be a rhetorical question. I am honestly requesting how I should proceed to help fixing the failing build. If this pull request is not the way to do it, please advice how I should proceed.

rdewaele commented Sep 22, 2017

I am sorry, this is really not intended to be a rhetorical question. I am honestly requesting how I should proceed to help fixing the failing build. If this pull request is not the way to do it, please advice how I should proceed.

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Sep 22, 2017

Contributor

I am honestly requesting how I should proceed to help fixing the failing build.

other PR is just waiting on me to update the resource blocks, which I will do ASAP. has nothing to do with a failing build.

Contributor

ilovezfs commented Sep 22, 2017

I am honestly requesting how I should proceed to help fixing the failing build.

other PR is just waiting on me to update the resource blocks, which I will do ASAP. has nothing to do with a failing build.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.