New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mosh: Rename from mobile-shell #18636

Closed
wants to merge 1 commit into
base: master
from

Conversation

3 participants
@daylightbrightledlight
Contributor

daylightbrightledlight commented Sep 28, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Renaming mobile-shell to mosh to be consistent with actual package name.
See: https://mosh.org/

@daylightbrightledlight

This comment has been minimized.

Show comment
Hide comment
@daylightbrightledlight

daylightbrightledlight Sep 28, 2017

Contributor

The cask mosh is actually a duplicate of this formula. Not sure why it's there.

Contributor

daylightbrightledlight commented Sep 28, 2017

The cask mosh is actually a duplicate of this formula. Not sure why it's there.

@daylightbrightledlight daylightbrightledlight referenced this pull request Sep 28, 2017

Closed

Removal mosh #39064

2 of 5 tasks complete

@commitay commitay referenced this pull request Sep 28, 2017

Merged

Remove mosh #39065

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Sep 28, 2017

Contributor

There's already a mosh alias so I don't think this is necessary but thanks for the PR nonetheless.

Contributor

ilovezfs commented Sep 28, 2017

There's already a mosh alias so I don't think this is necessary but thanks for the PR nonetheless.

@ilovezfs ilovezfs closed this Sep 28, 2017

@ilovezfs ilovezfs reopened this Sep 28, 2017

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Sep 28, 2017

Contributor

Changed my mind. There's enough references in the upstream project to mosh not mobile-shell that we might as well rename it.

Contributor

ilovezfs commented Sep 28, 2017

Changed my mind. There's enough references in the upstream project to mosh not mobile-shell that we might as well rename it.

@DomT4

This comment has been minimized.

Show comment
Hide comment
@DomT4

DomT4 Sep 29, 2017

Contributor

What's with the removal of revision 1 here?

Contributor

DomT4 commented Sep 29, 2017

What's with the removal of revision 1 here?

@ilovezfs ilovezfs closed this in 5d49294 Sep 29, 2017

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Sep 29, 2017

Contributor

Thanks for your first contribution to Homebrew, @daylightbrightledlight! Without people like you submitting PRs we couldn't run this project. You rock!

Contributor

ilovezfs commented Sep 29, 2017

Thanks for your first contribution to Homebrew, @daylightbrightledlight! Without people like you submitting PRs we couldn't run this project. You rock!

jooray added a commit to jooray/dotfiles that referenced this pull request Oct 25, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.