New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdk-pixbuf: make introspection optional #21240

Merged
merged 1 commit into from Dec 1, 2017

Conversation

Projects
None yet
2 participants
@jeroen
Contributor

jeroen commented Dec 1, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)? (no but unrelated existing issue)

Add an option to make gobject-introspection dependency optional, similar to e.g. gmime, harfbuzz, libsecret etc.

@jeroen

This comment has been minimized.

Show comment
Hide comment
@jeroen

jeroen Dec 1, 2017

Contributor

CI is failing due to an unrelated existing issue (use of ARGV) :( Should I look into that as well?

Contributor

jeroen commented Dec 1, 2017

CI is failing due to an unrelated existing issue (use of ARGV) :( Should I look into that as well?

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Dec 1, 2017

Contributor

@jeroen don't worry about that.

@GauthamGoli I think it may be a false positive with the new audit code.

Contributor

ilovezfs commented Dec 1, 2017

@jeroen don't worry about that.

@GauthamGoli I think it may be a false positive with the new audit code.

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Dec 1, 2017

Contributor

@jeroen why is this PR useful?

Contributor

ilovezfs commented Dec 1, 2017

@jeroen why is this PR useful?

@jeroen

This comment has been minimized.

Show comment
Hide comment
@jeroen

jeroen Dec 1, 2017

Contributor

The hard dependency on the GObjectIntrospection really complicates the build for static applications, and it is completely useless for most people.

It also breaks the build if homebrew in installed in non default directory:

==> Reinstalling gdk-pixbuf --without-modules --with-included-loaders=
==> Downloading https://download.gnome.org/sources/gdk-pixbuf/2.36/gdk-pixbuf-2.36.11.tar.xz
==> Downloading from http://ftp1.nluug.nl/windowing/gnome/sources/gdk-pixbuf/2.36/gdk-pixbuf-2.36.11.tar.xz
==> ./configure --disable-maintainer-mode --enable-debug=no --prefix=/private/var/folders/df/dg3_rt811j1g41_129pfhmg00000gn/T/build-librsvg/Cellar/gdk-pixbuf/2.36.11 --enable-introspection=yes --disable-Bsymbolic --enable-static --without-gdiplus --disable-modules --with-included-loaders=yes
==> make
Last 15 lines from /Users/builder/Library/Logs/Homebrew/gdk-pixbuf/02.make:
  CCLD     libstatic-pixbufloader-tiff.la
  CCLD     libgdk_pixbuf-2.0.la
  CCLD     gdk-pixbuf-csource
  CCLD     gdk-pixbuf-pixdata
  CCLD     gdk-pixbuf-query-loaders
  CCLD     test-gdk-pixbuf
  GISCAN   GdkPixbuf-2.0.gir
  GICOMP   GdkPixbuf-2.0.gir
Could not find GIR file 'GModule-2.0.gir'; check XDG_DATA_DIRS or use --includedir
error parsing file GdkPixbuf-2.0.gir: Failed to parse included gir GModule-2.0
make[4]: *** [GdkPixbuf-2.0.typelib] Error 1
make[3]: *** [all-recursive] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
Contributor

jeroen commented Dec 1, 2017

The hard dependency on the GObjectIntrospection really complicates the build for static applications, and it is completely useless for most people.

It also breaks the build if homebrew in installed in non default directory:

==> Reinstalling gdk-pixbuf --without-modules --with-included-loaders=
==> Downloading https://download.gnome.org/sources/gdk-pixbuf/2.36/gdk-pixbuf-2.36.11.tar.xz
==> Downloading from http://ftp1.nluug.nl/windowing/gnome/sources/gdk-pixbuf/2.36/gdk-pixbuf-2.36.11.tar.xz
==> ./configure --disable-maintainer-mode --enable-debug=no --prefix=/private/var/folders/df/dg3_rt811j1g41_129pfhmg00000gn/T/build-librsvg/Cellar/gdk-pixbuf/2.36.11 --enable-introspection=yes --disable-Bsymbolic --enable-static --without-gdiplus --disable-modules --with-included-loaders=yes
==> make
Last 15 lines from /Users/builder/Library/Logs/Homebrew/gdk-pixbuf/02.make:
  CCLD     libstatic-pixbufloader-tiff.la
  CCLD     libgdk_pixbuf-2.0.la
  CCLD     gdk-pixbuf-csource
  CCLD     gdk-pixbuf-pixdata
  CCLD     gdk-pixbuf-query-loaders
  CCLD     test-gdk-pixbuf
  GISCAN   GdkPixbuf-2.0.gir
  GICOMP   GdkPixbuf-2.0.gir
Could not find GIR file 'GModule-2.0.gir'; check XDG_DATA_DIRS or use --includedir
error parsing file GdkPixbuf-2.0.gir: Failed to parse included gir GModule-2.0
make[4]: *** [GdkPixbuf-2.0.typelib] Error 1
make[3]: *** [all-recursive] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Dec 1, 2017

Contributor

Ug … looks like the audacious test is stuck.

Contributor

ilovezfs commented Dec 1, 2017

Ug … looks like the audacious test is stuck.

@ilovezfs ilovezfs merged commit 28a48fa into Homebrew:master Dec 1, 2017

1 check failed

continuous-integration/jenkins/ghprb Build finished.
Details
@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Dec 1, 2017

Contributor

Thanks again @jeroen!

Contributor

ilovezfs commented Dec 1, 2017

Thanks again @jeroen!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.