Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttfautohint 1.8.1 #22321

Closed
wants to merge 1 commit into from
Closed

Conversation

lemzwerg
Copy link
Contributor

@lemzwerg lemzwerg commented Jan 1, 2018

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@lemzwerg lemzwerg force-pushed the ttfautohint-1.8.1 branch 2 times, most recently from 9d0a496 to 1b115d5 Compare January 1, 2018 17:17
@lemzwerg
Copy link
Contributor Author

lemzwerg commented Jan 1, 2018

I don't understand the failure message:

failed: brew linkage --test pdf2htmlex

Please advise.

@lemzwerg
Copy link
Contributor Author

lemzwerg commented Jan 2, 2018

Looking again at the issue, this can only be a bug in homebrew itself (or its setup on Jenkins), since ttfautohint has no connection to pdf2htmlex whatsoever.

@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 2, 2018

since ttfautohint has no connection to pdf2htmlex whatsoever.

That is not the case:

$ grep ttf $(brew formula pdf2htmlex)
  depends_on "ttfautohint"
$ brew uses ttfautohint | grep pdf
pdf2htmlex

this can only be a bug in homebrew

Yes, I broke it in #12226.

@lemzwerg
Copy link
Contributor Author

lemzwerg commented Jan 2, 2018

Hehe, yes :-) However, this can't be deduced from anything jenkins is emitting...

I've opened issue #22331

@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 2, 2018

However, this can't be deduced from anything jenkins is emitting

Then how did I deduce it?

@lemzwerg
Copy link
Contributor Author

lemzwerg commented Jan 2, 2018

Well, I don't use homebrew at all! I'm just innocently updating a formula as a courtesy to users, so it didn't hit me immediately that there are tests for reverse dependencies also...

@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 2, 2018

@BrewTestBot test this please

@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 2, 2018

Thanks @lemzwerg! Shipped.

@ilovezfs ilovezfs closed this in 6f0e115 Jan 2, 2018
@lemzwerg lemzwerg deleted the ttfautohint-1.8.1 branch January 2, 2018 07:58
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants