New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitcoin] Allow bitcoin to be compiled with optional zmq dependency #23088

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@mecampbellsoup
Contributor

mecampbellsoup commented Jan 19, 2018

Since the 0.12 release of bitcoin, it has been possible to utilize ZMQ for pub-sub messaging to allow bitcoind to communicate with other processes.

The UNIX installation docs list it as an optional dependency: https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#dependencies

Here are detailed docs in the bitcoin GH repo discussing how to make use of ZMQ.

In particular, ZMQ is needed to facilitate message passing from bitcoind to-and-from lnd. Here are docs from the Lightning team discussing how to wire up bitcoind to communicate with lnd.

@ilovezfs

This comment has been minimized.

Contributor

ilovezfs commented Jan 19, 2018

Let's require it. No need for an option.

@mecampbellsoup

This comment has been minimized.

Contributor

mecampbellsoup commented Jan 19, 2018

@ilovezfs SGTM. So remove the => :optional flag?

Once that change is made, the compilation process should report yes when checking for ZMQ, correct?

image

Strange that ZMQ isn't found during the build... perhaps not strange at all since I haven't made it a required dependency.

ZMQ not found during build

@ilovezfs

This comment has been minimized.

Contributor

ilovezfs commented Jan 19, 2018

yup

Options used to compile and link:
  with wallet   = yes
  with gui / qt = no
  with zmq      = yes
  with test     = yes
  with bench    = yes
  with upnp     = yes
  debug enabled = no
  werror        = no

just remove the => :optional

@ilovezfs

This comment has been minimized.

Contributor

ilovezfs commented Jan 19, 2018

also we should bump the revision here

@mecampbellsoup

This comment has been minimized.

Contributor

mecampbellsoup commented Jan 19, 2018

@ilovezfs where is the revision set, is that the sha256 macro?

@mecampbellsoup mecampbellsoup force-pushed the mecampbellsoup:add-zmq-support-for-bitcoin-recipe branch from 4cc212e to 1b5334f Jan 19, 2018

@ilovezfs

This comment has been minimized.

Contributor

ilovezfs commented Jan 19, 2018

here's an example 656e549

@mecampbellsoup

This comment has been minimized.

Contributor

mecampbellsoup commented Jan 19, 2018

Cool, it looks like there's no revision yet in the bitcoin.rb recipe, so just set it to revision 1? Or is it zero-index, i.e. revision 0?

@ilovezfs

This comment has been minimized.

Contributor

ilovezfs commented Jan 19, 2018

Counting starts from 0 but revision 0 is always left implicit.

@mecampbellsoup

This comment has been minimized.

Contributor

mecampbellsoup commented Jan 19, 2018

@ilovezfs cool I pushed a commit adding revision 1.

@mecampbellsoup

This comment has been minimized.

Contributor

mecampbellsoup commented Jan 19, 2018

@ilovezfs hm, build still failing - does this look familiar to you at all?

image

@ilovezfs

This comment has been minimized.

Contributor

ilovezfs commented Jan 19, 2018

@ilovezfs

This comment has been minimized.

Contributor

ilovezfs commented Jan 19, 2018

if you rebase this, it should build now

@mecampbellsoup mecampbellsoup force-pushed the mecampbellsoup:add-zmq-support-for-bitcoin-recipe branch from 6aee3b8 to e62bea1 Jan 20, 2018

@@ -11,6 +11,7 @@ class Bitcoin < Formula
patch do
url "https://github.com/bitcoin/bitcoin/commit/1ec0c0a01c31.patch?full_index=1"
sha256 "a1f761fe29f78e783cb4b55f8029900f94b45d1188cb81c80f73347ee2fdc025"
revision 1

This comment has been minimized.

@mecampbellsoup

mecampbellsoup Jan 20, 2018

Contributor

@ilovezfs revision inside this patch block, or outside?

This comment has been minimized.

@ilovezfs

ilovezfs Jan 20, 2018

Contributor

should go under homepage in this case

@mecampbellsoup mecampbellsoup force-pushed the mecampbellsoup:add-zmq-support-for-bitcoin-recipe branch from e62bea1 to b98bbfd Jan 20, 2018

@fxcoudert

This comment has been minimized.

Member

fxcoudert commented Jan 20, 2018

Thanks @mecampbellsoup for the pull request and congrats on your first contribution to Homebrew!

@fxcoudert fxcoudert closed this in d5b3e17 Jan 20, 2018

@mecampbellsoup mecampbellsoup deleted the mecampbellsoup:add-zmq-support-for-bitcoin-recipe branch Jan 21, 2018

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.