[bitcoin] Allow bitcoin to be compiled with optional zmq dependency #23088
Conversation
Let's require it. No need for an option. |
@ilovezfs SGTM. So remove the Once that change is made, the compilation process should report Strange that ZMQ isn't found during the build... perhaps not strange at all since I haven't made it a required dependency. |
yup
just remove the => :optional |
also we should bump the revision here |
@ilovezfs where is the revision set, is that the |
here's an example 656e549 |
Cool, it looks like there's no |
Counting starts from 0 but |
@ilovezfs cool I pushed a commit adding |
@ilovezfs hm, build still failing - does this look familiar to you at all? |
@mecampbellsoup it's this: bitcoin/bitcoin#12009 |
if you rebase this, it should build now |
@@ -11,6 +11,7 @@ class Bitcoin < Formula | |||
patch do | |||
url "https://github.com/bitcoin/bitcoin/commit/1ec0c0a01c31.patch?full_index=1" | |||
sha256 "a1f761fe29f78e783cb4b55f8029900f94b45d1188cb81c80f73347ee2fdc025" | |||
revision 1 |
ilovezfs
Jan 20, 2018
Contributor
should go under homepage in this case
should go under homepage in this case
b98bbfd
Thanks @mecampbellsoup for the pull request and congrats on your first contribution to Homebrew! |
Since the 0.12 release of
bitcoin
, it has been possible to utilize ZMQ for pub-sub messaging to allowbitcoind
to communicate with other processes.The UNIX installation docs list it as an optional dependency: https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#dependencies
Here are detailed docs in the
bitcoin
GH repo discussing how to make use of ZMQ.In particular, ZMQ is needed to facilitate message passing from
bitcoind
to-and-fromlnd
. Here are docs from the Lightning team discussing how to wire upbitcoind
to communicate withlnd
.