Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: use build script to maintain all ldflags #23360

Closed
wants to merge 1 commit into from

Conversation

cblecker
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This modifies the build process for dep to use the build script they use to publish real releases. This ensures that the version information is fully populated. It was also necessary to swap over to tag/revision from url/sha to accomplish this.

This ensures that if the project uses additional ldflags in the future, that they will be retained.

Before:

dep:
 version     : 0.4.1
 build date  : 
 git hash    : 
 go version  : go1.9.3
 go compiler : gc
 platform    : darwin/amd64

After:

dep:
 version     : v0.4.1
 build date  : 2018-01-27
 git hash    : 37d9ea0
 go version  : go1.9.3
 go compiler : gc
 platform    : darwin/amd64

@cblecker
Copy link
Contributor Author

I'm not sure what's up with the failure. Doesn't appear to be related, and doesn't appear when I run locally.

@ilovezfs
Copy link
Contributor

@cblecker it's caused by Homebrew/brew#2601

@cblecker
Copy link
Contributor Author

@ilovezfs I’m not sure what the right path would be to fix this, if that’s the case. We aren’t explicitly bumping the version, but swapping from url/sha -> tag/revision in order to expose that information in the version message

@ilovezfs ilovezfs closed this in 90b98d9 Jan 27, 2018
@ilovezfs
Copy link
Contributor

The right path is to ignore it, so I've merged this! Thanks for the PR. At some point, we will need to fix it on the brew side, but since it only occurs once during the checksum -> tag transition, I haven't bothered anyone about it yet or done anything about it myself.

@cblecker
Copy link
Contributor Author

Awesome! Thanks as always, @ilovezfs! 👍

@ilovezfs
Copy link
Contributor

You're welcome!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
@cblecker cblecker deleted the dep-tag branch July 4, 2018 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants