Skip to content

sslsplit 0.5.0 (new formula)#2401

Closed
cgroschupp wants to merge 1 commit into
Homebrew:masterfrom
cgroschupp:sslsplit-0.5.0
Closed

sslsplit 0.5.0 (new formula)#2401
cgroschupp wants to merge 1 commit into
Homebrew:masterfrom
cgroschupp:sslsplit-0.5.0

Conversation

@cgroschupp

Copy link
Copy Markdown
Contributor
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?

@cgroschupp
cgroschupp force-pushed the sslsplit-0.5.0 branch 3 times, most recently from 9fb2b52 to 76fcbec Compare June 26, 2016 16:05
Comment thread Formula/sslsplit.rb Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this works over https:// just fine.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@cgroschupp
cgroschupp force-pushed the sslsplit-0.5.0 branch 2 times, most recently from 91ffde1 to 504e838 Compare June 26, 2016 19:24
@DomT4 DomT4 added needs response Needs a response from the issue/PR author new formula PR adds a new formula to Homebrew/homebrew-core labels Jun 26, 2016
@ghost ghost removed the needs response Needs a response from the issue/PR author label Jun 26, 2016
@DomT4 DomT4 added the needs response Needs a response from the issue/PR author label Jun 29, 2016
@UniqMartin UniqMartin changed the title sslsplit 0.5.0 sslsplit 0.5.0 (new formula) Jul 6, 2016
Comment thread Formula/sslsplit.rb Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be using the block form of inreplace if inreplacing the same file twice.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"inreplace" is not more necessary.
droe/sslsplit@a81dbdb

@ghost ghost removed the needs response Needs a response from the issue/PR author label Aug 8, 2016
@dunn

dunn commented Aug 10, 2016

Copy link
Copy Markdown
Contributor

Comment thread Formula/sslsplit.rb Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the inreplace do format when inreplacing the same file more than once, Thanks!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dunn dunn added the needs response Needs a response from the issue/PR author label Aug 10, 2016
@MikeMcQuaid

Copy link
Copy Markdown
Member

@cgroschupp Could you update this based on the comments? Thanks!

@ghost ghost removed the needs response Needs a response from the issue/PR author label Sep 3, 2016
Comment thread Formula/sslsplit.rb Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check, have these issues been fixed in HEAD?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's fixed in the development branch.
droe/sslsplit@a81dbdb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

new formula PR adds a new formula to Homebrew/homebrew-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants