New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sslsplit 0.5.0 (new formula) #2401
Conversation
9fb2b52
to
76fcbec
Compare
class Sslsplit < Formula | ||
desc "man-in-the-middle attacks against SSL encrypted network connections" | ||
homepage "https://www.roe.ch/SSLsplit" | ||
url "http://mirror.roe.ch/rel/sslsplit/sslsplit-0.5.0.tar.bz2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this works over https://
just fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
91ffde1
to
504e838
Compare
|
||
def install | ||
ENV.deparallelize | ||
inreplace "GNUmakefile", "-o $(BINUID) -g $(BINGID)", "" # Remove UID 0,GID 0 setting for install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be using the block form of inreplace
if inreplacing the same file twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"inreplace" is not more necessary.
droe/sslsplit@a81dbdb
504e838
to
c635aef
Compare
def install | ||
if ! build.head? | ||
ENV.deparallelize | ||
inreplace "GNUmakefile", "-o $(BINUID) -g $(BINGID)", "" # Remove UID 0,GID 0 setting for install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the inreplace do
format when inreplacing the same file more than once, Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@cgroschupp Could you update this based on the comments? Thanks! |
c635aef
to
b00324c
Compare
depends_on "openssl" | ||
|
||
def install | ||
unless build.head? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to check, have these issues been fixed in HEAD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's fixed in the development branch.
droe/sslsplit@a81dbdb
b00324c
to
1916f5b
Compare
Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock! |
brew install <formula>
(where<formula>
is the name of the formula you're submitting)?brew audit --strict --online <formula>
(after doingbrew install <formula>
)?