Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sslsplit 0.5.0 (new formula) #2401

Closed
wants to merge 1 commit into from
Closed

sslsplit 0.5.0 (new formula) #2401

wants to merge 1 commit into from

Conversation

cgroschupp
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?

@cgroschupp cgroschupp force-pushed the sslsplit-0.5.0 branch 3 times, most recently from 9fb2b52 to 76fcbec Compare June 26, 2016 16:05
DomT4
DomT4 reviewed Jun 26, 2016
View reviewed changes
Formula/sslsplit.rb
class Sslsplit < Formula
desc "man-in-the-middle attacks against SSL encrypted network connections"
homepage "https://www.roe.ch/SSLsplit"
url "http://mirror.roe.ch/rel/sslsplit/sslsplit-0.5.0.tar.bz2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this works over https:// just fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@cgroschupp cgroschupp force-pushed the sslsplit-0.5.0 branch 2 times, most recently from 91ffde1 to 504e838 Compare June 26, 2016 19:24
@DomT4 DomT4 added needs response Needs a response from the issue/PR author new formula PR adds a new formula to Homebrew/homebrew-core labels Jun 26, 2016
@ghost ghost removed the needs response Needs a response from the issue/PR author label Jun 26, 2016
@DomT4 DomT4 added the needs response Needs a response from the issue/PR author label Jun 29, 2016
@UniqMartin UniqMartin changed the title sslsplit 0.5.0 sslsplit 0.5.0 (new formula) Jul 6, 2016
DomT4
DomT4 reviewed Aug 8, 2016
View reviewed changes
Formula/sslsplit.rb

def install
ENV.deparallelize
inreplace "GNUmakefile", "-o $(BINUID) -g $(BINGID)", "" # Remove UID 0,GID 0 setting for install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be using the block form of inreplace if inreplacing the same file twice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"inreplace" is not more necessary.
droe/sslsplit@a81dbdb

@ghost ghost removed the needs response Needs a response from the issue/PR author label Aug 8, 2016
@dunn
Copy link
Contributor

dunn commented Aug 10, 2016 •
edited

Just some audit warnings: https://bot.brew.sh/job/Homebrew%20Core%20Pull%20Requests/5974/version=yosemite/testReport/junit/brew-test-bot/yosemite/audit_sslsplit___new_formula/

DomT4
DomT4 reviewed Aug 10, 2016
View reviewed changes
Formula/sslsplit.rb
def install
if ! build.head?
ENV.deparallelize
inreplace "GNUmakefile", "-o $(BINUID) -g $(BINGID)", "" # Remove UID 0,GID 0 setting for install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the inreplace do format when inreplacing the same file more than once, Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dunn dunn added the needs response Needs a response from the issue/PR author label Aug 10, 2016
@MikeMcQuaid
Copy link
Member

@cgroschupp Could you update this based on the comments? Thanks!

@ghost ghost removed the needs response Needs a response from the issue/PR author label Sep 3, 2016
DomT4
DomT4 reviewed Sep 3, 2016
View reviewed changes
Formula/sslsplit.rb
depends_on "openssl"

def install
unless build.head?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check, have these issues been fixed in HEAD?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's fixed in the development branch.
droe/sslsplit@a81dbdb

@MikeMcQuaid
Copy link
Member

Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cgroschupp @dunn @MikeMcQuaid @DomT4