Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soundpipe 1.7.0 (new-formula) #28089

Closed
wants to merge 5 commits into from
Closed

soundpipe 1.7.0 (new-formula) #28089

wants to merge 5 commits into from

Conversation

@gabcoh
Copy link
Contributor

gabcoh commented May 22, 2018

Add a formula for the soundpipe library at
https://github.com/PaulBatchelor/soundpipe/
The library is installed just by make and make install

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Add a formula for the soundpipe library at
https://github.com/PaulBatchelor/soundpipe/
The library is installed just by make and make install
homepage "https://paulbatchelor.github.io/proj/soundpipe.html"
url "https://github.com/PaulBatchelor/soundpipe/archive/v1.7.0.tar.gz"
sha256 "2d6f6b155ad93d12f59ae30e2b0f95dceed27e0723147991da6defc6d65eadda"
depends_on "libsndfile"

This comment has been minimized.

Copy link
@fxcoudert

fxcoudert May 22, 2018

Member

Blank line before depends_on

system "make", "-C", "test"
cp_r "test", prefix
cp_r "examples", prefix
system "make", "install", "PREFIX="+prefix

This comment has been minimized.

Copy link
@fxcoudert

fxcoudert May 22, 2018

Member

PREFIX=#{prefix}

# While this command does test the library, it does so by printing out ok or
# not ok for various tests. A more thorough test would check to make sure
# that everything is ok before returning success.
system "cd #{prefix}/test;#{prefix}/test/run.bin"

This comment has been minimized.

Copy link
@fxcoudert

fxcoudert May 22, 2018

Member

Please check the output with assert_match and shell_output.

This comment has been minimized.

Copy link
@fxcoudert

fxcoudert May 22, 2018

Member

Another option would be to compile and link a simple C app, if the project ships a library.

def install
system "make"
system "make", "-C", "test"
cp_r "test", prefix

This comment has been minimized.

Copy link
@fxcoudert

fxcoudert May 22, 2018

Member

tests and examples should be installed to pkgshare.

gabcoh and others added 4 commits May 22, 2018
move test and examples to `pkgshare`. Test install by compiling example
program and checking output.
Fix error with `sha256sum` not being installed by using ruby hash
function
use double quotes instead of single quotes.
@fxcoudert

This comment has been minimized.

Copy link
Member

fxcoudert commented May 24, 2018

Thanks @gabcoh for the pull request!

@fxcoudert fxcoudert closed this in c7bece5 May 24, 2018
@lock lock bot added the outdated label Jun 23, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.