Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.7.0 #29490

Closed
wants to merge 76 commits into from

Conversation

Projects
None yet
4 participants
@sashkab
Copy link
Contributor

commented Jun 28, 2018

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@sashkab sashkab force-pushed the sashkab:python3.7.0 branch Jun 28, 2018

@sashkab

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2018

I think bumping revisions for failed packages should fix most of the errors detected in CI. Correct me if I'm wrong.

@oudingfan

This comment has been minimized.

Copy link

commented Jun 28, 2018

can't wait to update to python 3.7

@lithammer

This comment has been minimized.

Copy link

commented Jun 28, 2018

Out of curiosity, will 3.6 be available as python@3.6 or would I need to use pyenv for that?

@ilovezfs

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2018

There is no plan to add a python@3.6 at this time. See discussion on #10239

@ilovezfs

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2018

let's hold off on pushing more commits here for now

@ilovezfs

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2018

So far, I have fixes locally for

  • boost-python3
  • diffoscope
  • fdroidserver
  • flintrock
  • ipython
  • juju-wait
  • jupyter
  • khard
  • ocrmypdf
  • opencv
  • openimageio
  • pytouhou
  • root
  • shyaml
  • snakemake
  • snapcraft
  • twtxt
  • vim@7.4
  • yamllint
@ilovezfs

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2018

The root build failure is

/tmp/root-20180628-17694-yteyfj/root-6.14.00/bindings/pyroot/src/PyRootType.cxx:103:22: error: cannot initialize a variable of type 'char *' with an rvalue of type 'const char *'
               char* cppname = PyROOT_PyUnicode_AsString(pycppname);
                     ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

so probably can be fixed with a cast or just const char* cppname but I haven't tested.

Same issue for opencv.

@ilovezfs

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2018

vim@7.4 needs vim/vim@16d7ece

@ilovezfs

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2018

also have local fixes for opencv and root.

Feel free to push more commits. CI has calmed down

@sashkab

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2018

@ilovezfs how do you want to handle this PR? There are a lot of changes in many formulas, so not sure if I want to start resolving merge conflicts, or wait for you to push your local changes?

@ilovezfs ilovezfs force-pushed the sashkab:python3.7.0 branch 7 times, most recently Jun 29, 2018

@ilovezfs

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2018

@sashkab hopefully it'll be OK now except for conjure-up/conjure-up#1484. We shall see.

@ilovezfs ilovezfs referenced this pull request Jun 29, 2018

Closed

crystal-lang 0.25.1 #29527

4 of 4 tasks complete

@ilovezfs ilovezfs force-pushed the sashkab:python3.7.0 branch to 176823e Jun 29, 2018

@ilovezfs ilovezfs referenced this pull request Jun 29, 2018

Closed

Python 3.7 support #1484

@battlemidget battlemidget referenced this pull request Jun 30, 2018

Closed

conjure-up 2.5.9 #29575

4 of 4 tasks complete

@ilovezfs ilovezfs closed this in d3592c0 Jun 30, 2018

@ilovezfs

This comment has been minimized.

Copy link
Contributor

commented Jun 30, 2018

Thanks for the PR @sashkab! Shipped.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.