Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

musl-cross 0.9.2 (new formula) #2974

Closed
wants to merge 1 commit into from
Closed

musl-cross 0.9.2 (new formula) #2974

wants to merge 1 commit into from

Conversation

@FiloSottile
Copy link
Contributor

@FiloSottile FiloSottile commented Jul 13, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?

There's a README here, might be worth copying some of those instructions to Caveats https://gist.github.com/FiloSottile/01d2bbfaf63ae1b6e373e6bc874fefc6#file-z_readme-md

The musl-cross-make repo itself doesn't pass the popularity treshold, but it's onbly a wrapper to make cross-compilers with the hugely popular musl libc.

Also, AFAICT this is the only Formula that would install a cross-compilation toolkit out of the box.

@FiloSottile
Copy link
Contributor Author

@FiloSottile FiloSottile commented Jul 13, 2016

I noticed the failures on pre-El Capitan, but I don't have a machine to debug, help welcome.


bottle do
cellar :any_skip_relocation
end

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Jul 15, 2016
Member

Please remove this block, it'll be generated if this is pulled.

option "without-x86_64", "Do not build cross-compilers targeting x86_64-linux-musl"

depends_on "gnu-sed" => :build
depends_on "homebrew/dupes/make" => :build

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Jul 15, 2016
Member

Why can't this use the default make?

end

def install
ENV.deparallelize

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Jul 15, 2016
Member

Please report this upstream.

@MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jul 15, 2016

@FiloSottile
Copy link
Contributor Author

@FiloSottile FiloSottile commented Jul 16, 2016

I understand the specific GH repo does not match the requirements, but the repo is just the Makefile, to build a gcc with musl libc. That is the only way to use musl on OS X. And musl is definitely popular.

I'd like to ask for a more adhoc relevance decision.

Sent from a small keyboard

On 15 lug 2016, at 17:42, Mike McQuaid notifications@github.com wrote:

Closed #2974.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jul 16, 2016

I'd like to ask for a more adhoc relevance decision.

You can create your own tap and if that's popular then it'll be a stronger argument for inclusion.

@FiloSottile
Copy link
Contributor Author

@FiloSottile FiloSottile commented Jul 20, 2016

@raphaelcohn
Copy link
Contributor

@raphaelcohn raphaelcohn commented Oct 3, 2016

@FiloSottile Thanks for taking the time to produce this; being able to cross compile for musl from Mac OS X is extremely useful. I can now cross-compile Rust crates! Woo-hoo!

@jjpe
Copy link

@jjpe jjpe commented Jul 5, 2017

I'm somewhat confused: when I brew search for musl, I get this output:

$ brew search musl-cross

No formula found for "musl-cross".
Closed pull requests:
musl-cross 0.9.2 (new formula) (https://github.com/Homebrew/homebrew-core/pull/2974)

So basically I'm forwarded here. Could anyone please explain to me what's going on here?

@habibalamin
Copy link
Contributor

@habibalamin habibalamin commented Sep 20, 2017

@jjpe Homebrew is basically saying, “look, we don't officially support this formula, but someone did create one that never got merged in; you can install it from there if you really need it”.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants