Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wireguard-tools 0.0.20160722 (new formula) #3183

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@zx2c4
Copy link
Contributor

commented Jul 21, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?

Hello,

This is a formula for the wg(8) tool, for WireGuard. I'm the author of pass, which is already in here as pass.rb, so I'm somewhat familiar with brew maintenance. As part of the effort to make userspace implementations of WireGuard for OS X, getting the wireguard-tools package running smoothly on Homebrew is quite important. I expect for this package to become popular overtime. It has packages currently for Debian, Arch, OpenWRT, Gentoo, and OpenSUSE, with more on their way. The package ships with a man page as well, accessible at man wg.

Here's a screenshot after a successful brew installation:
wireguard-osx

Looking forward,
Jason

@zx2c4 zx2c4 changed the title wireguard-tools: add 0.0.20160721 (new formula) wireguard-tools 0.0.20160721 (new formula) Jul 21, 2016

@zx2c4 zx2c4 changed the title wireguard-tools 0.0.20160721 (new formula) wireguard-tools 0.0.20160722 (new formula) Jul 22, 2016

@DomT4

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2016

Hey @zx2c4. If there's no stable release for this at all at the present time this will be a better fit for our https://github.com/Homebrew/homebrew-devel-only tap. We try not to package purely experimental software in homebrew/core.

Besides that, this looks 👍. If you want to drop a PR to https://github.com/Homebrew/homebrew-devel-only happy to re-review & likely merge over there. Thanks!

@DomT4 DomT4 closed this Jul 23, 2016

@zx2c4

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2016

Hi @DomT4 -- Sorry for the confusion in version numbering, but in fact wireguard-tools is quite stable. It simply lives in the same repository and has the same snapshot release cycles of the currently experimental module for the Linux kernel. But the tools component, which is being packaged here, is very stable. Upstream could separate it into its own repository, but it's easiest just to keep the releases synchronized, at least for now.

So, this package is a good candidate for homebrew/core, especially as various implementations start to rely on it. And even if nothing else in homebrew/core marks this as a dependency, as a sysadmin tool subcomands like wg pubkey are very useful.

So, please reconsider!

Thanks,
Jason

@DomT4

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2016

Thanks, that's useful information. You did name the formula wireguard-tools so fair shout on me having missed that hint.

Is there some upstream confirmation they consider the tools stable? It'd be useful if they would cut a stable release for the tools, but I understand the lower maintenance burden around not doing so.

Maybe it's worth adding some notation to the formula that we don't have to update this incredibly regularly despite the experimental tag because the tools themselves are stable.

@DomT4 DomT4 reopened this Jul 23, 2016

@ghost ghost removed the needs response label Jul 23, 2016

@zx2c4

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2016

Hey @DomT4 -- I've just pushed a new package that adds a descriptive comment. Fortunately, in this case, I actually am upstream. I'll only be submitting pull requests to bump the version when it's relevant, and I'll include the tool-related changelog in the pull request messages.

@DomT4

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2016

I'll only be submitting pull requests to bump the version when it's relevant, and I'll include the tool-related changelog in the pull request messages.

Sadly I can't promise you you'll be the only one updating it. We don't really "do" the concept of individual formula maintainers, although there are a number of formula that require enough delicate dancing inevitably only a few people feel passionate enough to do so. That's more or less why the notation is a desirable thing.

@DomT4

View changes

Formula/wireguard-tools.rb Outdated
class WireguardTools < Formula
desc "Tools for the WireGuard secure network tunnel"
homepage "https://www.wireguard.io/"
# Though this tools package is from an experimental tag, these tools themselves are

This comment has been minimized.

Copy link
@DomT4

DomT4 Jul 24, 2016

Contributor

At the risk of being annoying (Which I specialise in), can we trim this a little bit? Something like:

# Despite the experimental tag the tools themselves are stable.
# Please only update version when the tools have been modified/updated.

@ghost ghost removed the needs response label Jul 24, 2016

@zx2c4

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2016

Hi @DomT4 -- I trimmed the comment and pushed a new revision. I think we should be all set now!

@apjanke

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2016

LGTM. 👍

@DomT4 DomT4 closed this in 38e4e0b Jul 26, 2016

@DomT4

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2016

Yeah, this is fine. I've just been drowned by life lately & hadn't had time to pull yet.

Merged in 38e4e0b. Thank you for your contribution to Homebrew @zx2c4; we appreciate it! 😺

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.