Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rakudo 2018.12 (new formula) #34785

Closed
wants to merge 3 commits into from
Closed

rakudo 2018.12 (new formula) #34785

wants to merge 3 commits into from

Conversation

atweiden
Copy link
Contributor

@atweiden atweiden commented Dec 4, 2018

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@atweiden atweiden changed the title Rakudo rakudo 2018.11 (new formula) Dec 4, 2018
@BrewTestBot
Copy link
Member

  • Dependency 'libffi' may be unnecessary as it is provided by macOS; try to build this formula without it.
  • Dependency 'libffi' may be unnecessary as it is provided by macOS; try to build this formula without it.
  • Formulae should not have a HEAD spec

@BrewTestBot
Copy link
Member

  • Formulae should not have a HEAD spec

@javian javian added the new formula PR adds a new formula to Homebrew/homebrew-core label Dec 4, 2018
javian
javian previously requested changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@javian javian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some initial thoughts.

Formula/nqp.rb Show resolved Hide resolved
Formula/nqp.rb Outdated Show resolved Hide resolved
Formula/nqp.rb Outdated Show resolved Hide resolved
Formula/moarvm.rb Outdated Show resolved Hide resolved
Formula/moarvm.rb Show resolved Hide resolved
Formula/rakudo.rb Outdated Show resolved Hide resolved
Formula/rakudo.rb Outdated Show resolved Hide resolved
Formula/moarvm.rb Outdated Show resolved Hide resolved
@kivikakk
Copy link
Contributor

Using this locally and it's working well! Would love to see this get merged.

@atweiden atweiden changed the title rakudo 2018.11 (new formula) rakudo 2018.12 (new formula) Dec 22, 2018
fxcoudert
fxcoudert reviewed Dec 31, 2018
View reviewed changes
Formula/moarvm.rb Outdated Show resolved Hide resolved
fxcoudert
fxcoudert reviewed Dec 31, 2018
View reviewed changes
Formula/moarvm.rb Outdated Show resolved Hide resolved
fxcoudert
fxcoudert reviewed Dec 31, 2018
View reviewed changes
Formula/moarvm.rb Outdated Show resolved Hide resolved
fxcoudert
fxcoudert requested changes Dec 31, 2018
View reviewed changes
Formula/moarvm.rb Outdated Show resolved Hide resolved
Formula/moarvm.rb Outdated Show resolved Hide resolved
Formula/nqp.rb Outdated Show resolved Hide resolved
Formula/nqp.rb Outdated Show resolved Hide resolved
Formula/nqp.rb Outdated Show resolved Hide resolved
Formula/rakudo.rb Outdated Show resolved Hide resolved
Formula/rakudo.rb Outdated Show resolved Hide resolved
Formula/rakudo.rb Outdated Show resolved Hide resolved
Formula/rakudo.rb Outdated Show resolved Hide resolved
Formula/rakudo.rb Outdated Show resolved Hide resolved
@fxcoudert
Copy link
Member

What is the difference between rakudo-star, for which we already have a formula, and these three different formulas?

@atweiden
Copy link
Contributor Author

atweiden commented Jan 1, 2019

@fxcoudert

What is the difference between rakudo-star, for which we already have a formula, and these three different formulas?

rakudo-star isn't as actively maintained as each of moarvm nqp and rakudo, which see monthly releases individually.

rakudo-star ships extra Perl 6 modules which are not included in the standard Rakudo distribution.

Also, instead of downloading/building moarvm and nqp together under a single bloated rakudo-star package, each dep is compiled/installed separately with checksums validated.

fxcoudert
fxcoudert requested changes Jan 1, 2019
View reviewed changes
Formula/moarvm.rb Outdated Show resolved Hide resolved
Formula/moarvm.rb Outdated Show resolved Hide resolved
Formula/moarvm.rb Outdated Show resolved Hide resolved
Formula/moarvm.rb Outdated Show resolved Hide resolved
Formula/nqp.rb Outdated Show resolved Hide resolved
Formula/nqp.rb Outdated Show resolved Hide resolved
Formula/rakudo.rb Outdated Show resolved Hide resolved
Formula/rakudo.rb Outdated Show resolved Hide resolved
Formula/rakudo.rb Outdated Show resolved Hide resolved
Formula/rakudo.rb
"--with-nqp=#{Formula["nqp"].bin}/nqp"
system "make"
system "make", "install"
bin.install "tools/install-dist.p6" => "perl6-install-dist"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you comment: if upstream does not wish to install this under bin (and thus put it in the user's PATH), why would we force this (and rename the tool)? Do other distros/vendors do this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, on Void Linux, we have perl6-install-dist to support installing Perl 6 modules with xbps. Note the file install-dist.p6 doesn't get installed anywhere on disk unless we manually place it into bin.

@fxcoudert fxcoudert added the almost there PR is nearly ready to merge label Jan 1, 2019
@BrewTestBot
Copy link
Member

  • Dependency 'libffi' may be unnecessary as it is provided by macOS; try to build this formula without it.

@fxcoudert
Copy link
Member

Thanks @atweiden for the pull request!

@fxcoudert fxcoudert closed this in bb456f8 Jan 7, 2019
@atweiden atweiden deleted the rakudo branch January 8, 2019 00:15
@lock lock bot added the outdated PR was locked due to age label Feb 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fxcoudert fxcoudert fxcoudert approved these changes

@javian javian javian left review comments

Assignees
No one assigned
Labels
almost there PR is nearly ready to merge new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@atweiden @BrewTestBot @kivikakk @fxcoudert @javian