New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charm and charm tools #350

Closed
wants to merge 2 commits into
base: master
from

Conversation

2 participants
@marcoceppi
Contributor

marcoceppi commented Apr 15, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Does your submission pass brew audit --strict --online <formula> (where <formula> is the name of the formula you're submitting)?
  • Have you built your formula locally prior to submission with brew install <formula>?

@marcoceppi marcoceppi changed the title from Charm and charm tools to charm and charm tools Apr 16, 2016

sha256 "4fe4cad12684442b2fa26cc2a5a3258a359b1e5a72fe9c9d6532fddb4f1e0bbc" => :el_capitan
sha256 "fb69f3d68c12c81a242e6e8e89d50cf50269547ddd83a1c072dcc2dae56703a3" => :yosemite
sha256 "fb0efbe87f759e3a014feb49067590a3c8fd4b002bf41bdaf2547da8a06f7671" => :mavericks
end

This comment has been minimized.

@tdsmith

tdsmith Apr 16, 2016

Contributor

Where did you get these? In any case, you don't need to touch/provide the bottle block when submitting PRs or new formulas.

@tdsmith

tdsmith Apr 16, 2016

Contributor

Where did you get these? In any case, you don't need to touch/provide the bottle block when submitting PRs or new formulas.

This comment has been minimized.

@marcoceppi

marcoceppi Apr 16, 2016

Contributor

This is what has been in the charm-tools formula for years, I just copied
it over. Should I just completely remove the bottle block?

On Fri, Apr 15, 2016, 8:28 PM tim smith notifications@github.com wrote:

In Formula/charm.rb
#350 (comment):

@@ -0,0 +1,25 @@
+class Charm < Formula

  • bottle do
  • cellar :any_skip_relocation
  • sha256 "4fe4cad12684442b2fa26cc2a5a3258a359b1e5a72fe9c9d6532fddb4f1e0bbc" => :el_capitan
  • sha256 "fb69f3d68c12c81a242e6e8e89d50cf50269547ddd83a1c072dcc2dae56703a3" => :yosemite
  • sha256 "fb0efbe87f759e3a014feb49067590a3c8fd4b002bf41bdaf2547da8a06f7671" => :mavericks
  • end

Where did you get these? In any case, you don't need to touch/provide the
bottle block when submitting PRs or new formulas.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/Homebrew/homebrew-core/pull/350/files/ec8d010278485ce3ac61ea7cd0f011ab651a3e6f#r59961654

@marcoceppi

marcoceppi Apr 16, 2016

Contributor

This is what has been in the charm-tools formula for years, I just copied
it over. Should I just completely remove the bottle block?

On Fri, Apr 15, 2016, 8:28 PM tim smith notifications@github.com wrote:

In Formula/charm.rb
#350 (comment):

@@ -0,0 +1,25 @@
+class Charm < Formula

  • bottle do
  • cellar :any_skip_relocation
  • sha256 "4fe4cad12684442b2fa26cc2a5a3258a359b1e5a72fe9c9d6532fddb4f1e0bbc" => :el_capitan
  • sha256 "fb69f3d68c12c81a242e6e8e89d50cf50269547ddd83a1c072dcc2dae56703a3" => :yosemite
  • sha256 "fb0efbe87f759e3a014feb49067590a3c8fd4b002bf41bdaf2547da8a06f7671" => :mavericks
  • end

Where did you get these? In any case, you don't need to touch/provide the
bottle block when submitting PRs or new formulas.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/Homebrew/homebrew-core/pull/350/files/ec8d010278485ce3ac61ea7cd0f011ab651a3e6f#r59961654

This comment has been minimized.

@tdsmith

tdsmith Apr 16, 2016

Contributor

It's different from the hashes in charm-tools.rb! It's fine; I was just curious.

@tdsmith

tdsmith Apr 16, 2016

Contributor

It's different from the hashes in charm-tools.rb! It's fine; I was just curious.

@tdsmith tdsmith closed this in bf73cba Apr 16, 2016

@tdsmith

This comment has been minimized.

Show comment
Hide comment
@tdsmith

tdsmith Apr 16, 2016

Contributor

Thanks for your pull request! 🎉 Homebrew thrives because of contributions like this one.

Contributor

tdsmith commented Apr 16, 2016

Thanks for your pull request! 🎉 Homebrew thrives because of contributions like this one.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.