New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poppler 0.73.0 #35785

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@jeroen
Copy link
Contributor

jeroen commented Jan 8, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Upstream has renamed some cmake variables, see release notes

@jeroen jeroen force-pushed the jeroen:poppler branch from 63b8808 to 2ab413f Jan 8, 2019

@jeroen

This comment has been minimized.

Copy link
Contributor

jeroen commented Jan 8, 2019

Hmm it looks like reverse dependency pdftoedn is using some deprecated api's which have now been removed 🤦

@SMillerDev

This comment has been minimized.

Copy link
Contributor

SMillerDev commented Jan 8, 2019

edporras/pdftoedn#5 is the upstream issue for that.

@jeroen jeroen force-pushed the jeroen:poppler branch 2 times, most recently from ffb7fd7 to aa604e1 Jan 8, 2019

@edporras

This comment has been minimized.

Copy link
Contributor

edporras commented Jan 8, 2019

I have released pdftoedn-0.36.4 (sha256: 4714f2525a41574ad8601b5d68d82975615a52475088fa9f02e83ecb7a68b363) and submitted a PR to resolve pdftoipe

@jeroen jeroen force-pushed the jeroen:poppler branch from aa604e1 to 481d649 Jan 8, 2019

@jeroen

This comment has been minimized.

Copy link
Contributor

jeroen commented Jan 8, 2019

OK thank you! I have updated this PR.

@jeroen jeroen force-pushed the jeroen:poppler branch 2 times, most recently from a1987f3 to c8e14be Jan 9, 2019

@jeroen

This comment has been minimized.

Copy link
Contributor

jeroen commented Jan 9, 2019

Yay this finally passes all tests and audits 🎉 @SMillerDev

@jeroen jeroen force-pushed the jeroen:poppler branch from c8e14be to 3f87911 Jan 9, 2019

@fxcoudert

This comment has been minimized.

Copy link
Member

fxcoudert commented Jan 10, 2019

Thanks @jeroen for the pull request!

@fxcoudert fxcoudert closed this in 8822dcf Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment