New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update caveat text to point to correct folder to source #35817

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
2 participants
@iandol
Copy link
Contributor

iandol commented Jan 9, 2019

See https://discourse.brew.sh/t/bash-completion-and-brew-instructions-for-setting-up-completions/3808

On both my Ubuntu and macOS brew installs, bash completions are found in [brew --prefix]/etc/bash_completion.d yet the caveat instructions considers brew_completion as a file to source, rather than source all files within the bash_completion.d folder. Is bash_completion.d where everyone else finds their completions?

Also update the main documentation @ Homebrew/brew#5511

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Update caveat text to point to correct folder to source
See https://discourse.brew.sh/t/bash-completion-and-brew-instructions-for-setting-up-completions/3808

On both my Ubuntu and macOS brew installs, bash completions are found in `[brew --prefix]/etc/bash_completion.d` yet the caveat instructions considers `brew_completion` as a file to source, rather than source all files within the `bash_completion.d` folder. Is `bash_completion.d` where everyone else finds their completions?

Also update the main documentation @ Homebrew/brew#5511

@fxcoudert fxcoudert merged commit 87302a4 into Homebrew:master Jan 10, 2019

1 check passed

continuous-integration/jenkins/ghprb Build finished.
Details
@fxcoudert

This comment has been minimized.

Copy link
Member

fxcoudert commented Jan 10, 2019

Thanks @iandol !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment