New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fnm 1.2.0 (new formula) #36744

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@flesch
Copy link

flesch commented Feb 5, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot

This comment has been minimized.

Copy link
Contributor

BrewTestBot commented Feb 5, 2019

  • GitHub repository too new (<30 days old)

@flesch flesch referenced this pull request Feb 5, 2019

Open

Release a Homebrew formula #5

@SMillerDev

This comment has been minimized.

Copy link
Contributor

SMillerDev commented Feb 5, 2019

Hi, this seems like a nice software, but not notable enough for us to package in Homebrew for now. This is not a decision on the merits of the software, but we cannot distribute every single piece of software and have to draw a line on “notability” somewhere. Of course, we would be happy to reconsider in the future.

Please consider hosting it in a personal tap, which is very easy to do: https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap

@SMillerDev SMillerDev closed this Feb 5, 2019

@SMillerDev

This comment has been minimized.

Copy link
Contributor

SMillerDev commented Feb 5, 2019

For the next attempt to get this into core (when your repo has been around for a bit longer) please keep in mind that any code in homebrew-core has to be build from source and has to be licensed under a valid OSI license.

@Schniz

This comment has been minimized.

Copy link

Schniz commented Feb 5, 2019

You're totally right about the license - I forgot to add one.
Thanks for your detailed response!

Thanks @flesch again for submitting it. Let's wait for a couple of months before trying to submit it again 😸

@flesch

This comment has been minimized.

Copy link
Author

flesch commented Feb 5, 2019

Thanks @SMillerDev for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment