New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibana 6.6.0 rebuild 1 #36821

Closed
wants to merge 8 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@mistic
Copy link
Contributor

mistic commented Feb 8, 2019

This PR fixes an issue with the current formula which was not including some assets folders introduced on v6.6.0. More info about the problem could be found elastic/kibana#30186

@fxcoudert we need to generate new bottles, built with this PR formula, and also adding a bottle revision. Also, do you have any idea why we have such a complex formula, building almost everything from source, when a simpler and quicker solution would just be downloading the official built artifact that already includes everything we need?

mistic added some commits Feb 8, 2019

@fxcoudert

This comment has been minimized.

Copy link
Member

fxcoudert commented Feb 8, 2019

Homebrew ships open source software, built from source.

@mistic

This comment has been minimized.

Copy link
Contributor Author

mistic commented Feb 8, 2019

@fxcoudert thanks for the info. The idea was just prevent things like that to happening in the future, but I can agree with the Homebrew policy. I changed the logic behind which files/folder include from the build which could help avoid some other similar situations in the future.

mistic added some commits Feb 8, 2019

@mistic

This comment has been minimized.

Copy link
Contributor Author

mistic commented Feb 8, 2019

@fxcoudert it looks like the build is green! Do you think we can get this merged please?

@fxcoudert

This comment has been minimized.

Copy link
Member

fxcoudert commented Feb 10, 2019

poke @chrmoritz: does this seem ok to you?

@chrmoritz

This comment has been minimized.

Copy link
Contributor

chrmoritz commented Feb 10, 2019

Yeah, sure. Ideally we should find a test, which actually tests some functionality too, but I guess this could be quite difficult here.

@fxcoudert

This comment has been minimized.

Copy link
Member

fxcoudert commented Feb 10, 2019

Thanks @mistic for the pull request!

@fxcoudert fxcoudert closed this in 9db8e0b Feb 10, 2019

@chrmoritz chrmoritz referenced this pull request Feb 10, 2019

Closed

kibana formula installs incomplete kibana version 6.6.0 #36857

4 of 6 tasks complete

cdeccio added a commit to cdeccio/homebrew-core that referenced this pull request Feb 12, 2019

kibana: add missing assets
Closes Homebrew#36821.

Signed-off-by: FX Coudert <fxcoudert@gmail.com>

cdeccio added a commit to cdeccio/homebrew-core that referenced this pull request Feb 12, 2019

kibana: add missing assets
Closes Homebrew#36821.

Signed-off-by: FX Coudert <fxcoudert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment