Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upKibana 6.6.0 rebuild 1 #36821
Conversation
mistic
added some commits
Feb 8, 2019
mistic
referenced this pull request
Feb 8, 2019
Closed
"Kibana did not load properly" after upgrading from 6.5.4 to 6.6.0 #30186
This comment has been minimized.
This comment has been minimized.
|
Homebrew ships open source software, built from source. |
This comment has been minimized.
This comment has been minimized.
|
@fxcoudert thanks for the info. The idea was just prevent things like that to happening in the future, but I can agree with the |
mistic
added some commits
Feb 8, 2019
This comment has been minimized.
This comment has been minimized.
|
@fxcoudert it looks like the build is green! Do you think we can get this merged please? |
This comment has been minimized.
This comment has been minimized.
|
poke @chrmoritz: does this seem ok to you? |
This comment has been minimized.
This comment has been minimized.
|
Yeah, sure. Ideally we should find a test, which actually tests some functionality too, but I guess this could be quite difficult here. |
fxcoudert
added
the
ready to merge
label
Feb 10, 2019
This comment has been minimized.
This comment has been minimized.
|
Thanks @mistic for the pull request! |
fxcoudert
closed this
in
9db8e0b
Feb 10, 2019
chrmoritz
referenced this pull request
Feb 10, 2019
Closed
kibana formula installs incomplete kibana version 6.6.0 #36857
added a commit
to cdeccio/homebrew-core
that referenced
this pull request
Feb 12, 2019
added a commit
to cdeccio/homebrew-core
that referenced
this pull request
Feb 12, 2019
mistic commentedFeb 8, 2019
This PR fixes an issue with the current formula which was not including some assets folders introduced on
v6.6.0. More info about the problem could be found elastic/kibana#30186@fxcoudert we need to generate new bottles, built with this PR formula, and also adding a bottle revision. Also, do you have any idea why we have such a complex formula, building almost everything from source, when a simpler and quicker solution would just be downloading the official built artifact that already includes everything we need?