Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cig: use godep to load dependencies #37613

Closed
wants to merge 1 commit into from
Closed

cig: use godep to load dependencies #37613

wants to merge 1 commit into from

Conversation

andrew
Copy link
Contributor

@andrew andrew commented Mar 5, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

cig already has godep listed as a dependency but didn't actually use it to restore dependencies, instead used the deprecated go_resource, this PR cleans that up.

@fxcoudert
Copy link
Member

Thanks @andrew

@fxcoudert fxcoudert closed this in 17d62a6 Mar 5, 2019
@lock lock bot added the outdated PR was locked due to age label Apr 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants