Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator-sdk 0.5.0 (new formula) #37826

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@cblecker
Copy link
Contributor

cblecker commented Mar 12, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Add a new formula for the operator-sdk tool.

@cblecker

This comment has been minimized.

Copy link
Contributor Author

cblecker commented Mar 13, 2019

Looks like CI is green. Please let me know if anything else is required on my part :)

@SMillerDev

This comment has been minimized.

Copy link
Contributor

SMillerDev commented Mar 13, 2019

All dependencies should either be vendored in the formula or be a formula themselves. No downloading is allowed in the install block.
In addition to that, is the coreos project really the owner of this? Or is the homepage just an explanation of operator?

@cblecker

This comment has been minimized.

Copy link
Contributor Author

cblecker commented Mar 13, 2019

@SMillerDev There are a number of formulas (such as kubernetes-helm) that code their dependencies via something like glide/dep, and then download at build time.. so that's not a hard and fast rule.

However, it looks like this isn't needed in this case. While the install directions suggest you should run make dep, it appears that all needed dependencies are in the repo's vendor folder. I've removed this step to simplify the formula.

Yes, the CoreOS site is the official site -- it's listed as such on the repo's homepage: https://github.com/operator-framework/operator-sdk

@cblecker cblecker force-pushed the cblecker:operator-sdk branch from c2fd119 to 6436e99 Mar 13, 2019

@SMillerDev

This comment has been minimized.

Copy link
Contributor

SMillerDev commented Mar 13, 2019

While it might not be checked well all the time it's actually one of the rules in https://docs.brew.sh/Acceptable-Formulae

@cblecker

This comment has been minimized.

Copy link
Contributor Author

cblecker commented Mar 13, 2019

CI is green after changes :)

@cblecker

This comment has been minimized.

Copy link
Contributor Author

cblecker commented Mar 15, 2019

@SMillerDev are there any other changes required, or does this now meet the requirements to merge? Thank you!

@fxcoudert

This comment has been minimized.

Copy link
Member

fxcoudert commented Mar 18, 2019

Thanks @cblecker

@fxcoudert fxcoudert closed this in f5ba125 Mar 18, 2019

@cblecker cblecker deleted the cblecker:operator-sdk branch Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.