Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearch 7.0.0 #38966

Closed
wants to merge 2 commits into from
Closed

Conversation

ogidow
Copy link

@ogidow ogidow commented Apr 16, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@@ -1,8 +1,8 @@
class Elasticsearch < Formula
desc "Distributed search & analytics engine"
homepage "https://www.elastic.co/products/elasticsearch"
url "https://artifacts.elastic.co/downloads/elasticsearch/elasticsearch-oss-6.7.0.tar.gz"
sha256 "ffe589cf2e74a44a35f059338fdef30dffcb7196d6bfd916d64173b32c9a2451"
url "https://artifacts.elastic.co/downloads/elasticsearch/elasticsearch-oss-7.0.0-darwin-x86_64.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this contain precompiled software specific to macOS?

@fxcoudert
Copy link
Member

Hi, thanks for the pull request! Homebrew formulas need to build from source to be acceptable in the core repository: https://docs.brew.sh/Acceptable-Formulae

@chrmoritz
Copy link
Contributor

Also all beats which are still at version 6.2.0 won't be compatible with elasticsearch 7. With 7.0 we can make filebeat oss only compatible, but all other beats (except the already migrated auditbeat and metricbeat) will be incompatible with elasticsearch 7. https://www.elastic.co/de/support/matrix#matrix_compatibility

I think the elastic 7.0 upgrade will get quite complicated here.

@fxcoudert
Copy link
Member

OK, closing for now until we have a coherent migration plan.

@fxcoudert fxcoudert closed this Apr 16, 2019
@lock lock bot added the outdated PR was locked due to age label May 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants